Re: [PATCH v2] net: rfkill: add generic gpio rfkill driver

["John W. Linville" <linville@tuxdriver.com>]

On Fri, May 13, 2011 at 12:02:54PM -0700, Rhyland Klein wrote:
> On Fri, 2011-05-13 at 00:15 -0700, Johannes Berg wrote:
> > On Thu, 2011-05-12 at 14:23 -0700, Rhyland Klein wrote:
> > > On Thu, 2011-05-12 at 12:02 -0700, Johannes Berg wrote:
> > > > On Thu, 2011-05-12 at 11:52 -0700, Rhyland Klein wrote:
> > > > 
> > > > > > If, on the other hand, rfkill decides that at the time of loading the
> > > > > > driver wifi should be on, then the first change would be +1 and it'll
> > > > > > flip between 0 and +1.
> > > > > > 
> > > > > > This seems like it'll cause issues at some point, so I think you should
> > > > > > either allow the driver to set the initial state or hardcode one of
> > > > > > these possibilities (so at least it's predictable)
> > > > 
> > > > > I won't go negative, if you look, it only will disable clock if it knows
> > > > > it has already enabled it. 
> > > > 
> > > > Ah, you're right, I misread the macros.
> > 
> > > So the patch is good as is?
> > 
> > I think so, yes.
> > 
> > johannes
> > 
> 
> John, Johannes suggested you are able to pull in this patch?

I've got it, thanks.

-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.