From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: "Mike Rapoport" <mike@compulab.co.il>,
Tony.Lindgren.tony@atomide.com,
"Enric Balletb� i Serra" <eballetbo@gmail.com>,
linux-omap@vger.kernel.org
Subject: Re: [RESEND PATCH 2/4] omap: igep0020: minor refactoring
Date: Fri, 13 May 2011 20:44:38 +0200 [thread overview]
Message-ID: <201105132044.39163.arnd@arndb.de> (raw)
In-Reply-To: <91dd03e6af514a628fc4d797066f3ef0d971b802.1305235542.git.mike@compulab.co.il>
On Thursday 12 May 2011, Mike Rapoport wrote:
> @@ -299,17 +299,14 @@ static struct omap2_hsmmc_info mmc[] = {
> static struct gpio_led igep_gpio_leds[] = {
> [0] = {
> .name = "gpio-led:red:d0",
> - .gpio = IGEP2_GPIO_LED0_RED,
> .default_trigger = "default-off"
> },
> [1] = {
> .name = "gpio-led:green:d0",
> - .gpio = IGEP2_GPIO_LED0_GREEN,
> .default_trigger = "default-off",
> },
> [2] = {
> .name = "gpio-led:red:d1",
> - .gpio = IGEP2_GPIO_LED1_RED,
> .default_trigger = "default-off",
> },
> [3] = {
> @@ -335,6 +332,10 @@ static struct platform_device igep_led_device = {
>
> static void __init igep_leds_init(void)
> {
> + igep_gpio_leds[0].gpio = IGEP2_GPIO_LED0_RED;
> + igep_gpio_leds[1].gpio = IGEP2_GPIO_LED0_GREEN;
> + igep_gpio_leds[2].gpio = IGEP2_GPIO_LED1_RED;
> +
> platform_device_register(&igep_led_device);
> }
Hi Mike,
Overall, the series looks great, but I'm somewhat worried by the fact that you
have to replace data structures with code in order to get there. Are there any
other options to do this?
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND PATCH 2/4] omap: igep0020: minor refactoring
Date: Fri, 13 May 2011 20:44:38 +0200 [thread overview]
Message-ID: <201105132044.39163.arnd@arndb.de> (raw)
In-Reply-To: <91dd03e6af514a628fc4d797066f3ef0d971b802.1305235542.git.mike@compulab.co.il>
On Thursday 12 May 2011, Mike Rapoport wrote:
> @@ -299,17 +299,14 @@ static struct omap2_hsmmc_info mmc[] = {
> static struct gpio_led igep_gpio_leds[] = {
> [0] = {
> .name = "gpio-led:red:d0",
> - .gpio = IGEP2_GPIO_LED0_RED,
> .default_trigger = "default-off"
> },
> [1] = {
> .name = "gpio-led:green:d0",
> - .gpio = IGEP2_GPIO_LED0_GREEN,
> .default_trigger = "default-off",
> },
> [2] = {
> .name = "gpio-led:red:d1",
> - .gpio = IGEP2_GPIO_LED1_RED,
> .default_trigger = "default-off",
> },
> [3] = {
> @@ -335,6 +332,10 @@ static struct platform_device igep_led_device = {
>
> static void __init igep_leds_init(void)
> {
> + igep_gpio_leds[0].gpio = IGEP2_GPIO_LED0_RED;
> + igep_gpio_leds[1].gpio = IGEP2_GPIO_LED0_GREEN;
> + igep_gpio_leds[2].gpio = IGEP2_GPIO_LED1_RED;
> +
> platform_device_register(&igep_led_device);
> }
Hi Mike,
Overall, the series looks great, but I'm somewhat worried by the fact that you
have to replace data structures with code in order to get there. Are there any
other options to do this?
Arnd
next prev parent reply other threads:[~2011-05-14 20:34 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-12 21:31 [PATCH 0/4] omap: merge IGEP v2 and v3 Mike Rapoport
2011-05-12 21:40 ` [RESEND PATCH " Mike Rapoport
2011-05-12 21:31 ` [PATCH 1/4] omap: igep0020: name refactoring for future merge with IGEP3 Mike Rapoport
2011-05-12 21:40 ` [RESEND PATCH " Mike Rapoport
2011-05-16 7:15 ` Enric Balletbò i Serra
2011-05-16 7:15 ` Enric Balletbò i Serra
2011-05-17 7:53 ` Tony Lindgren
2011-05-17 7:53 ` Tony Lindgren
2011-05-17 7:57 ` Enric Balletbò i Serra
2011-05-17 7:57 ` Enric Balletbò i Serra
2011-05-17 10:33 ` Tony Lindgren
2011-05-17 10:33 ` Tony Lindgren
2011-05-18 9:05 ` Igor Grinberg
2011-05-18 9:05 ` Igor Grinberg
2011-05-12 21:31 ` [PATCH 2/4] omap: igep0020: minor refactoring Mike Rapoport
2011-05-12 21:40 ` [RESEND PATCH " Mike Rapoport
2011-05-13 18:44 ` Arnd Bergmann [this message]
2011-05-13 18:44 ` Arnd Bergmann
2011-05-15 18:50 ` mike
2011-05-15 18:50 ` mike at compulab.co.il
2011-05-15 20:27 ` Arnd Bergmann
2011-05-15 20:27 ` Arnd Bergmann
2011-05-16 7:17 ` Enric Balletbò i Serra
2011-05-16 7:17 ` Enric Balletbò i Serra
2011-05-12 21:31 ` [PATCH 3/4] omap: igep0020: add support for IGEP3 Mike Rapoport
2011-05-12 21:40 ` [RESEND PATCH " Mike Rapoport
2011-05-16 7:16 ` Enric Balletbò i Serra
2011-05-12 21:31 ` [PATCH 4/4] omap: drop board-igep0030.c Mike Rapoport
2011-05-12 21:40 ` [RESEND PATCH " Mike Rapoport
2011-05-16 7:18 ` Enric Balletbò i Serra
2011-05-16 7:18 ` Enric Balletbò i Serra
2011-05-13 7:27 ` [RESEND PATCH 0/4] omap: merge IGEP v2 and v3 Enric Balletbò i Serra
2011-05-13 7:27 ` Enric Balletbò i Serra
2011-05-13 8:42 ` mike
2011-05-13 8:42 ` mike at compulab.co.il
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201105132044.39163.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=Tony.Lindgren.tony@atomide.com \
--cc=eballetbo@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=mike@compulab.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.