Re: [PATCH] carl9170: advertise interface combinations

[Christian Lamparter <chunkeey@googlemail.com>]

On Saturday 14 May 2011 01:28:20 Johannes Berg wrote:
> On Sat, 2011-05-14 at 00:35 +0200, Christian Lamparter wrote:
> > In order to provide multiple interfaces for a single device,
> > the driver is now required to advertise all possible
> > interface configurations to the stack.
> 
> Cool, thanks! Note that currently it's not yet required, but
> whatever :-)
"currently" :D

"I want to make you aware that I plan to remove the
WIPHY_FLAG_ENFORCE_COMBINATIONS flag again soon, so that all
drivers that don't advertise valid combinations will not be able to have
multiple virtual interfaces."

> > with the standard firmware, iw now displays:
> > 	[...]
> >         valid interface combinations:
> >                  * #{ IBSS, managed, AP, P2P-client, P2P-GO } <= 2,
> >                    total <= 2, #channels <= 1
> 
> Since mac80211 doesn't allow multiple IBSS interfaces, I think you
> should leave that out. And I should probably make mac80211 complain if
> it's advertised erroneously.
what about "valid" configurations like:
1 IBSS + 1 AP [STA/P2P make less sense]? 
(only one IBSS)

Regards,
	Chr