From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Andy Lutomirski <luto@MIT.EDU>
Cc: Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
ibm-acpi-devel@lists.sourceforge.net,
platform-driver-x86@vger.kernel.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Bruce Hill <bruce@slackwarebox.com>
Subject: Re: [PATCH v3] thinkpad-acpi: Improve hardware volume controls
Date: Sat, 14 May 2011 16:47:44 +0100 [thread overview]
Message-ID: <20110514154744.GB15681@srcf.ucam.org> (raw)
In-Reply-To: <75329ac2644b3832911882e23e9308c3dc88518c.1305386829.git.luto@mit.edu>
On Sat, May 14, 2011 at 11:34:25AM -0400, Andy Lutomirski wrote:
> It turns out that we can ask ACPI for one of three behaviors
> directly. They are "latch" (the default), "none" (no automatic
> control), and "toggle" (mute unmutes when muted). So we let the
> user control the mode through sysfs, and we don't generate KEY_MUTE
> in any mode other than "none".
>
> As an added bonus, we fix an old bug: the hardware mute control
> doesn't generate an ALSA change notification on newer ThinkPads.
Which of these modes make sense for userspace? "none" sounds like it'd
be fine, except that the LED wouldn't work on new machines. So should we
just be setting "toggle" in all cases? The optimal situation would be
that we delete the OSI blacklist at the same time as we add this code.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2011-05-14 15:47 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-09 22:18 [RFC PATCH] thinkpad-acpi: Improve hardware volume controls Andy Lutomirski
2011-05-09 23:53 ` Henrique de Moraes Holschuh
2011-05-10 0:38 ` Andrew Lutomirski
2011-05-10 1:04 ` [ibm-acpi-devel] " Henrique de Moraes Holschuh
2011-05-10 2:36 ` Andrew Lutomirski
2011-05-10 3:41 ` Andrew Lutomirski
2011-05-10 10:27 ` Henrique de Moraes Holschuh
2011-05-10 10:39 ` Andrew Lutomirski
[not found] ` <BANLkTikgKj9yBUTLiFVj4tP2LNSzbExo1A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-05-10 10:44 ` [PATCH v2] " Andy Lutomirski
2011-05-10 10:25 ` [ibm-acpi-devel] [RFC PATCH] " Henrique de Moraes Holschuh
2011-05-12 13:48 ` Matthew Garrett
2011-05-12 14:24 ` Andrew Lutomirski
2011-05-12 14:39 ` Matthew Garrett
2011-05-12 14:50 ` Andrew Lutomirski
[not found] ` <BANLkTikX7mMu2me6+O1e-Ub=Cbzerd=J3Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-05-12 15:39 ` Dmitry Torokhov
2011-05-12 19:33 ` Andrew Lutomirski
2011-05-12 20:42 ` Dmitry Torokhov
2011-05-14 15:34 ` [PATCH v3] " Andy Lutomirski
2011-05-14 15:47 ` Matthew Garrett [this message]
2011-05-14 15:55 ` Andrew Lutomirski
2011-05-14 18:41 ` Henrique de Moraes Holschuh
2011-05-15 19:22 ` Andrew Lutomirski
2011-05-12 21:43 ` [RFC PATCH] " Henrique de Moraes Holschuh
2011-05-16 13:49 ` [PATCH v4] " Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110514154744.GB15681@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=bruce@slackwarebox.com \
--cc=dmitry.torokhov@gmail.com \
--cc=hmh@hmh.eng.br \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=luto@MIT.EDU \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.