From: Ted Ts'o <tytso@mit.edu>
To: Tao Ma <tm@tao.ma>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] mke2fs: Make s_inodes_per_group >= 8 in ext2fs_initialize.
Date: Sat, 14 May 2011 23:28:58 -0400 [thread overview]
Message-ID: <20110515032858.GF21165@thunk.org> (raw)
In-Reply-To: <1304955522-4148-1-git-send-email-tm@tao.ma>
On Mon, May 09, 2011 at 11:38:42PM +0800, Tao Ma wrote:
> From: Tao Ma <boyu.mt@taobao.com>
>
> current mkfs.ext4 fails if we tried with the following parameters.
> mkfs.ext4 -m 0 -N 16 -O ^has_journal,^resize_inode,^uninit_bg,extent,meta_bg -b 1024 /dev/sdb3
> It will cause segfault, but it is caused by another issue. See my patch
> "mke2fs: Avoid segmentation fault in ext2fs_alloc_generic_bmap". And
> with that patch, the mkfs.ext4 will fail with the error:
> /dev/sdb3: Memory allocation failed while setting up superblock
>
> The reason is that in ext2fs_initialize, we align s_inodes_per_group
> to 8, but fails to consider the case that s_inodes_per_group < 8.
> So make at least 8 inodes for s_inodes_per_group.
>
> Signed-off-by: Tao Ma <boyu.mt@taobao.com>
Thanks, I've added this to the "next" branch of e2fsprogs.
- Ted
prev parent reply other threads:[~2011-05-15 3:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-09 15:38 [PATCH] mke2fs: Make s_inodes_per_group >= 8 in ext2fs_initialize Tao Ma
2011-05-15 3:28 ` Ted Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110515032858.GF21165@thunk.org \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=tm@tao.ma \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.