From: Ted Ts'o <tytso@mit.edu>
To: Allison Henderson <achender@linux.vnet.ibm.com>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH v2] NULL pointer when make_indexed_dir returns -ENOSPC
Date: Sun, 15 May 2011 00:21:08 -0400 [thread overview]
Message-ID: <20110515042108.GJ21165@thunk.org> (raw)
In-Reply-To: <4DCC1FF8.6040103@linux.vnet.ibm.com>
On Thu, May 12, 2011 at 10:59:20AM -0700, Allison Henderson wrote:
> Hi all,
>
> I wasnt sure if people were expecting a v2 for this one, but I
> noticed the modified version of v1 was removed from the tree, so I
> am assuming we needed v2? This one handles marking the buffer dirty
> before calling do split to avoid the null pointer. It introduces a
> little overhead, but the only other option would be to introduce a
> new flag set to do_split. But if there's any one that would prefer
> the flags to this solution, please let me know. Thx! :)
>
> Allison Henderson
>
> Signed-off-by: Allison Henderson <achender@us.ibm.com>
Applied, thanks. In the future, I'd appreciate it if you resent the
patch with a formal commit description. I recreated the commit
description from the older patch in this case.
- Ted
next prev parent reply other threads:[~2011-05-15 4:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-12 17:59 [PATCH v2] NULL pointer when make_indexed_dir returns -ENOSPC Allison Henderson
2011-05-15 4:21 ` Ted Ts'o [this message]
2011-05-15 15:05 ` Allison Henderson
2011-05-17 17:44 ` Jan Kara
2011-05-18 15:23 ` Allison Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110515042108.GJ21165@thunk.org \
--to=tytso@mit.edu \
--cc=achender@linux.vnet.ibm.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.