From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:46460) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QLdWl-0006Z7-EP for qemu-devel@nongnu.org; Sun, 15 May 2011 11:46:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QLdWk-0007D3-0S for qemu-devel@nongnu.org; Sun, 15 May 2011 11:46:43 -0400 Received: from hall.aurel32.net ([88.191.126.93]:32991) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QLdWj-0007Cz-SB for qemu-devel@nongnu.org; Sun, 15 May 2011 11:46:41 -0400 Date: Sun, 15 May 2011 17:46:38 +0200 From: Aurelien Jarno Message-ID: <20110515154638.GD24378@volta.aurel32.net> References: <1305468801-6015-1-git-send-email-aurelien@aurel32.net> <1305468801-6015-3-git-send-email-aurelien@aurel32.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Subject: Re: [Qemu-devel] [PATCH 02/11] target-mips/gdbstub: remove old CONFIG_SOFTFLOAT #ifdef List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel@nongnu.org On Sun, May 15, 2011 at 03:29:21PM +0100, Peter Maydell wrote: > On 15 May 2011 15:13, Aurelien Jarno wrote: > > target-mips has been switched to softfloat only long ago, but a > > few #ifdef CONFIG_SOFTFLOAT have been forgotten. Remove them. > > > -#ifndef CONFIG_SOFTFLOAT > >             /* no floating point exception for native float */ > >             SET_FP_ENABLE(env->active_fpu.fcr31, 0); > > -#endif > > Shouldn't the whole of this section be removed? This is > an #ifndef, not a #ifdef... > Yes good catch, it's a mistake from my side. I have fixed it locally, I'll send it at the same time of the next version of the series. -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net