diff for duplicates of <20110516084558.GE5279@suse.de> diff --git a/a/1.txt b/N1/1.txt index 11eb049..7901331 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -75,7 +75,3 @@ consider the zone balanced for prolonged periods of time. -- Mel Gorman SUSE Labs --- -To unsubscribe from this list: send the line "unsubscribe linux-ext4" in -the body of a message to majordomo@vger.kernel.org -More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index 07f8c8d..151b14e 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -100,10 +100,6 @@ "\n" "-- \n" "Mel Gorman\n" - "SUSE Labs\n" - "--\n" - "To unsubscribe from this list: send the line \"unsubscribe linux-ext4\" in\n" - "the body of a message to majordomo@vger.kernel.org\n" - More majordomo info at http://vger.kernel.org/majordomo-info.html + SUSE Labs -1e642d6ec7f56750e2da94cdf70e0f2ef4ec8c4e6dd40c9a93ada6b555ca68d6 +a83cfe198c0c922cbb694638f0e79486e49df35ab6180786855da897f734d685
diff --git a/a/1.txt b/N2/1.txt index 11eb049..3c861c1 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -9,27 +9,27 @@ On Mon, May 16, 2011 at 02:04:00PM +0900, Minchan Kim wrote: > >> > > >> > Signed-off-by: Mel Gorman<mgorman@suse.de> > >> > --- -> >> > mm/vmscan.c | 4 ++++ -> >> > 1 files changed, 4 insertions(+), 0 deletions(-) +> >> > mm/vmscan.c | 4 ++++ +> >> > 1 files changed, 4 insertions(+), 0 deletions(-) > >> > > >> > diff --git a/mm/vmscan.c b/mm/vmscan.c > >> > index af24d1e..4d24828 100644 > >> > --- a/mm/vmscan.c > >> > +++ b/mm/vmscan.c > >> > @@ -2251,6 +2251,10 @@ static bool sleeping_prematurely(pg_data_t *pgdat, int order, long remaining, -> >> > unsigned long balanced = 0; -> >> > bool all_zones_ok = true; +> >> > unsigned long balanced = 0; +> >> > bool all_zones_ok = true; > >> > -> >> > + /* If kswapd has been running too long, just sleep */ -> >> > + if (need_resched()) -> >> > + return false; +> >> > + /* If kswapd has been running too long, just sleep */ +> >> > + if (need_resched()) +> >> > + return false; > >> > + > >> > >> Hmm... I don't like this patch so much. because this code does > >> > >> - don't sleep if kswapd got context switch at shrink_inactive_list > > -> > This isn't entirely true: need_resched() will be false, so we'll follow +> > This isn't entirely true: need_resched() will be false, so we'll follow > > the normal path for determining whether to sleep or not, in effect > > leaving the current behaviour unchanged. > > @@ -38,13 +38,13 @@ On Mon, May 16, 2011 at 02:04:00PM +0900, Minchan Kim wrote: > > This also isn't entirely true: whether need_resched() is true at this > > point depends on a whole lot more that whether we did a context switch > > in shrink_inactive. It mostly depends on how long we've been running -> > without giving up the CPU. Generally that will mean we've been round +> > without giving up the CPU. Generally that will mean we've been round > > the shrinker loop hundreds to thousands of times without sleeping. > > > >> It seems to be semi random behavior. > > -> > Well, we have to do something. Chris Mason first suspected the hang was -> > a kswapd rescheduling problem a while ago. We tried putting +> > Well, we have to do something. Chris Mason first suspected the hang was +> > a kswapd rescheduling problem a while ago. We tried putting > > cond_rescheds() in several places in the vmscan code, but to no avail. > > Is it a result of test with patch of Hannes(ie, !pgdat_balanced)? @@ -61,7 +61,7 @@ On Mon, May 16, 2011 at 02:04:00PM +0900, Minchan Kim wrote: > kswapd consumes CPU a lot. > > > The need_resched() in sleeping_prematurely() seems to be about the best -> > option. The other option might be just to put a cond_resched() in +> > option. The other option might be just to put a cond_resched() in > > kswapd_try_to_sleep(), but that will really have about the same effect. > > I don't oppose it but before that, I think we have to know why kswapd @@ -75,7 +75,10 @@ consider the zone balanced for prolonged periods of time. -- Mel Gorman SUSE Labs + -- -To unsubscribe from this list: send the line "unsubscribe linux-ext4" in -the body of a message to majordomo@vger.kernel.org -More majordomo info at http://vger.kernel.org/majordomo-info.html +To unsubscribe, send a message with 'unsubscribe linux-mm' in +the body to majordomo@kvack.org. For more info on Linux MM, +see: http://www.linux-mm.org/ . +Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ +Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> diff --git a/a/content_digest b/N2/content_digest index 07f8c8d..5030f2a 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -35,27 +35,27 @@ "> >> >\n" "> >> > Signed-off-by: Mel Gorman<mgorman@suse.de>\n" "> >> > ---\n" - "> >> > \302\240 mm/vmscan.c | \302\240 \302\2404 ++++\n" - "> >> > \302\240 1 files changed, 4 insertions(+), 0 deletions(-)\n" + "> >> > mm/vmscan.c | 4 ++++\n" + "> >> > 1 files changed, 4 insertions(+), 0 deletions(-)\n" "> >> >\n" "> >> > diff --git a/mm/vmscan.c b/mm/vmscan.c\n" "> >> > index af24d1e..4d24828 100644\n" "> >> > --- a/mm/vmscan.c\n" "> >> > +++ b/mm/vmscan.c\n" "> >> > @@ -2251,6 +2251,10 @@ static bool sleeping_prematurely(pg_data_t *pgdat, int order, long remaining,\n" - "> >> > \302\240 \302\240 unsigned long balanced = 0;\n" - "> >> > \302\240 \302\240 bool all_zones_ok = true;\n" + "> >> > unsigned long balanced = 0;\n" + "> >> > bool all_zones_ok = true;\n" "> >> >\n" - "> >> > + \302\240 /* If kswapd has been running too long, just sleep */\n" - "> >> > + \302\240 if (need_resched())\n" - "> >> > + \302\240 \302\240 \302\240 \302\240 \302\240 return false;\n" + "> >> > + /* If kswapd has been running too long, just sleep */\n" + "> >> > + if (need_resched())\n" + "> >> > + return false;\n" "> >> > +\n" "> >>\n" "> >> Hmm... I don't like this patch so much. because this code does\n" "> >>\n" "> >> - don't sleep if kswapd got context switch at shrink_inactive_list\n" "> >\n" - "> > This isn't entirely true: \302\240need_resched() will be false, so we'll follow\n" + "> > This isn't entirely true: need_resched() will be false, so we'll follow\n" "> > the normal path for determining whether to sleep or not, in effect\n" "> > leaving the current behaviour unchanged.\n" "> >\n" @@ -64,13 +64,13 @@ "> > This also isn't entirely true: whether need_resched() is true at this\n" "> > point depends on a whole lot more that whether we did a context switch\n" "> > in shrink_inactive. It mostly depends on how long we've been running\n" - "> > without giving up the CPU. \302\240Generally that will mean we've been round\n" + "> > without giving up the CPU. Generally that will mean we've been round\n" "> > the shrinker loop hundreds to thousands of times without sleeping.\n" "> >\n" "> >> It seems to be semi random behavior.\n" "> >\n" - "> > Well, we have to do something. \302\240Chris Mason first suspected the hang was\n" - "> > a kswapd rescheduling problem a while ago. \302\240We tried putting\n" + "> > Well, we have to do something. Chris Mason first suspected the hang was\n" + "> > a kswapd rescheduling problem a while ago. We tried putting\n" "> > cond_rescheds() in several places in the vmscan code, but to no avail.\n" "> \n" "> Is it a result of test with patch of Hannes(ie, !pgdat_balanced)?\n" @@ -87,7 +87,7 @@ "> kswapd consumes CPU a lot.\n" "> \n" "> > The need_resched() in sleeping_prematurely() seems to be about the best\n" - "> > option. \302\240The other option might be just to put a cond_resched() in\n" + "> > option. The other option might be just to put a cond_resched() in\n" "> > kswapd_try_to_sleep(), but that will really have about the same effect.\n" "> \n" "> I don't oppose it but before that, I think we have to know why kswapd\n" @@ -101,9 +101,12 @@ "-- \n" "Mel Gorman\n" "SUSE Labs\n" + "\n" "--\n" - "To unsubscribe from this list: send the line \"unsubscribe linux-ext4\" in\n" - "the body of a message to majordomo@vger.kernel.org\n" - More majordomo info at http://vger.kernel.org/majordomo-info.html + "To unsubscribe, send a message with 'unsubscribe linux-mm' in\n" + "the body to majordomo@kvack.org. For more info on Linux MM,\n" + "see: http://www.linux-mm.org/ .\n" + "Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/\n" + "Don't email: <a href=mailto:\"dont@kvack.org\"> email@kvack.org </a>" -1e642d6ec7f56750e2da94cdf70e0f2ef4ec8c4e6dd40c9a93ada6b555ca68d6 +7b6eef095e32cd93d916b5de61e5575c0f9a6894d41ab7e58f1e2d499b8a689d
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.