From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Date: Mon, 16 May 2011 14:47:47 +0000 Subject: Re: [lm-sensors] [PATCH] hwmon: (abituguru) Depend on DMI Message-Id: <20110516144747.GA31057@ericsson.com> List-Id: References: <20110516110612.49ed4204@endymion.delvare> In-Reply-To: <20110516110612.49ed4204@endymion.delvare> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: lm-sensors@vger.kernel.org On Mon, May 16, 2011 at 05:06:12AM -0400, Jean Delvare wrote: > The abituguru drivers are only built on X86, where DMI support is now > enabled by default. So let these drivers depend on DMI, for the > following gains: > * Robustness and safety. Detection of these devices is weak and uses > non-standard methods, it should really be limited to Abit boards > unless the user explicitly asks otherwise. > * Code simplicity. The code is easier to read without ifdefs. > * Better build testing coverage. Now there's only one way to build the > drivers, so no risk of build failure on exotic systems. > > Signed-off-by: Jean Delvare > Cc: Alistair John Strachan > Cc: Hans de Goede Acked-by: Guenter Roeck _______________________________________________ lm-sensors mailing list lm-sensors@lm-sensors.org http://lists.lm-sensors.org/mailman/listinfo/lm-sensors