All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Shreshtha Kumar SAHU <shreshthakumar.sahu@stericsson.com>
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
	rmk+kernel@arm.linux.org.uk, linus.walleij@stericsson.com,
	alan@linux.intel.com
Subject: Re: [PATCH 1/2] amba pl011: workaround for uart registers lockup
Date: Mon, 16 May 2011 10:29:58 -0700	[thread overview]
Message-ID: <20110516172958.GA13011@kroah.com> (raw)
In-Reply-To: <1305550879-28945-1-git-send-email-shreshthakumar.sahu@stericsson.com>

On Mon, May 16, 2011 at 06:31:18PM +0530, Shreshtha Kumar SAHU wrote:
> From: Shreshtha Kumar Sahu <shreshthakumar.sahu@stericsson.com>
> 
> This workaround aims to break the deadlock situation
> which raises during continuous transfer of data for long
> duration over uart with hardware flow control. It is
> observed that CTS interrupt cannot be cleared in uart
> interrupt register (ICR). Hence further transfer over
> uart gets blocked.
> 
> It is seen that during such deadlock condition ICR
> don't get cleared even on multiple write. This leads
> pass_counter to decrease and finally reach zero. This
> can be taken as trigger point to run this UART_BT_WA.
> 
> Workaround backups the register configuration, does soft
> reset of UART using BIT-0 of PRCC_K_SOFTRST_SET/CLEAR
> registers and restores the registers.
> 
> This patch also provides support for uart init and exit
> function calls if present.
> 
> Signed-off-by: Shreshtha Kumar Sahu <shreshthakumar.sahu@stericsson.com>

Please always run your patches through scripts/checkpatch.pl so we don't
end up telling you to fix up the same obvious things that this tool
would tell you needs to be fixed...

thanks,

greg k-h

  parent reply	other threads:[~2011-05-16 17:31 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-16 13:01 [PATCH 1/2] amba pl011: workaround for uart registers lockup Shreshtha Kumar SAHU
2011-05-16 13:01 ` Shreshtha Kumar SAHU
2011-05-16 13:01 ` [PATCH 2/2] amba pl011: platform data for reg lockup and glitch Shreshtha Kumar SAHU
2011-05-16 13:01   ` Shreshtha Kumar SAHU
2011-05-16 13:09   ` Russell King
2011-05-16 14:00     ` Shreshtha Kumar SAHU
2011-05-16 14:05       ` Russell King
2011-05-16 14:15         ` Shreshtha Kumar SAHU
2011-05-17  5:23           ` [PATCHv2 " Shreshtha Kumar SAHU
2011-05-17  5:23             ` Shreshtha Kumar SAHU
2011-05-16 17:29 ` Greg KH [this message]
2011-05-17  5:20   ` [PATCHv2 1/2] amba pl011: workaround for uart registers lockup Shreshtha Kumar SAHU
2011-05-17  5:20     ` Shreshtha Kumar SAHU
2011-05-17 18:23     ` Greg KH
2011-05-17 18:30       ` Russell King
2011-05-17 18:40         ` Greg KH
2011-05-17 18:45           ` Russell King
2011-05-17 18:51       ` Greg KH
2011-06-09 19:46         ` Linus Walleij
2011-06-09 20:11           ` Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2011-06-09 20:56 [PATCH " Linus Walleij
2011-06-09 20:56 ` Linus Walleij
2011-06-13  8:11 Linus Walleij
2011-06-13  8:11 ` Linus Walleij
2011-06-16  8:17 ` Linus Walleij
2011-06-16  8:17   ` Linus Walleij
2011-06-16 15:16   ` Greg KH
2011-06-16 15:16     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110516172958.GA13011@kroah.com \
    --to=greg@kroah.com \
    --cc=alan@linux.intel.com \
    --cc=linus.walleij@stericsson.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=rmk+kernel@arm.linux.org.uk \
    --cc=shreshthakumar.sahu@stericsson.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.