From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:49229)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1QM2Bd-0002Cl-Sp
	for qemu-devel@nongnu.org; Mon, 16 May 2011 14:06:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1QM2Bc-0000JO-Me
	for qemu-devel@nongnu.org; Mon, 16 May 2011 14:06:33 -0400
Received: from hall.aurel32.net ([88.191.126.93]:52346)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1QM2Bc-0000I5-I2
	for qemu-devel@nongnu.org; Mon, 16 May 2011 14:06:32 -0400
Date: Mon, 16 May 2011 20:06:28 +0200
From: Aurelien Jarno <aurelien@aurel32.net>
Message-ID: <20110516180628.GS30615@hall.aurel32.net>
References: <1303401708-5419-1-git-send-email-peter.maydell@linaro.org>
	<BANLkTi=MBpJvbW+hgGOFHBVJUj5o_PoL+Q@mail.gmail.com>
	<20110514213247.GB13600@volta.aurel32.net>
	<201105161710.59650.paul@codesourcery.com>
	<BANLkTinwsj9LUbU4Mk-JTCQac-bhD=izhA@mail.gmail.com>
	<20110516172926.GA6132@volta.aurel32.net>
	<BANLkTikY-5eowi58XXOhdN=3xaYcopn=pQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <BANLkTikY-5eowi58XXOhdN=3xaYcopn=pQ@mail.gmail.com>
Sender: Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH] target-arm: Minimal implementation of
 performance counters
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, Paul Brook <paul@codesourcery.com>, patches@linaro.org

On Mon, May 16, 2011 at 06:47:42PM +0100, Peter Maydell wrote:
> On 16 May 2011 18:29, Aurelien Jarno <aurelien@aurel32.net> wrote:
> > On Mon, May 16, 2011 at 05:37:03PM +0100, Peter Maydell wrote:
> >> You can do this by calling GETPC() from the top level helper function
> >> though, right? [OK, we'd need to move the definition out of dyngen-exec.h.]
> >
> > No we don't need to move it out of dyngen-exec.h. dyngen-exec.h is
> > included in target-*/exec.h, as the softmmu helpers, which are included
> > in target-*/op_helper.c, call cpu_restore_state().
> 
> I meant, assuming we want to reduce the set of helpers which use
> the implicit-global-env (ie: back out the patches which made
> helpers other than op_helper.c include exec.h). At the moment
> you can't get GETPC() without also getting the global-env which
> means you have to be in a source file compiled with the right CFLAGS.
> Sorry for the lack of clarity.

Well, I haven't tried, but it seems you can simply include dyngen-exec.h
directly in the file you want. 

-- 
Aurelien Jarno	                        GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net