From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Makefile.package.in: Makes it possible to override the default extract commands
Date: Mon, 16 May 2011 21:52:26 +0200 [thread overview]
Message-ID: <20110516215226.26540f2a@surf> (raw)
In-Reply-To: <20110510204332.62afd066@surf>
Hello Allan,
On Tue, 10 May 2011 20:43:32 +0200
Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote:
> > +# default extract command
> > +$(2)_EXTRACT_CMDS ?= $(if $($(2)_SOURCE),$(INFLATE$(suffix
> > $($(2)_SOURCE))) $(DL_DIR)/$($(2)_SOURCE) | \
> > + $(TAR) $(TAR_STRIP_COMPONENTS)=1 -C $$($(2)_DIR)
> > $(TAR_OPTIONS) -)
>
> Hm, this is not some nice. I'm currently testing your patch, I'll see
> if I find a better way of writing this.
I haven't really searched a better way of writing this, but I've used
your patch and found some problem with it. It does not quote
sufficiently the variables, so things break with host packages.
I have been able to get things working with:
diff --git a/package/Makefile.package.in b/package/Makefile.package.in
index 9949b58..0a4c220 100644
--- a/package/Makefile.package.in
+++ b/package/Makefile.package.in
@@ -425,7 +425,8 @@ $(2)_TARGET_CLEAN = $$($(2)_DIR)/.stamp_cleaned
$(2)_TARGET_DIRCLEAN = $$($(2)_DIR)/.stamp_dircleaned
# default extract command
-$(2)_EXTRACT_CMDS ?= $(if $($(2)_SOURCE),$(INFLATE$(suffix $($(2)_SOURCE))) $(DL_DIR)/$($(2)_SOURCE) | \
+$(2)_EXTRACT_CMDS ?= \
+ $$(if $$($(2)_SOURCE),$$(INFLATE$$(suffix $$($(2)_SOURCE))) $(DL_DIR)/$$($(2)_SOURCE) | \
$(TAR) $(TAR_STRIP_COMPONENTS)=1 -C $$($(2)_DIR) $(TAR_OPTIONS)
-)
On top of what you did.
Regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2011-05-16 19:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-10 11:34 [Buildroot] Custom extract command agian agian Allan W. Nielsen
2011-05-10 11:34 ` [Buildroot] [PATCH] Makefile.package.in: Makes it possible to override the default extract commands Allan W. Nielsen
2011-05-10 18:43 ` Thomas Petazzoni
2011-05-16 19:52 ` Thomas Petazzoni [this message]
2011-05-18 14:39 ` Allan Nielsen
2011-05-18 15:27 ` Thomas Petazzoni
2011-05-18 16:05 ` Allan Nielsen
-- strict thread matches above, loose matches on Subject: below --
2011-05-19 6:25 a at awn.dk
2011-05-10 9:58 [Buildroot] Custom extract command again Allan W. Nielsen
2011-05-10 9:58 ` [Buildroot] [PATCH] Makefile.package.in: Makes it possible to override the default extract commands Allan W. Nielsen
2011-05-10 9:55 [Buildroot] Custom extract command again Allan W. Nielsen
2011-05-10 9:55 ` [Buildroot] [PATCH] Makefile.package.in: Makes it possible to override the default extract commands Allan W. Nielsen
2011-04-11 11:08 [Buildroot] New version of patch to provide custom extract procedures Allan W. Nielsen
2011-04-11 11:08 ` [Buildroot] [PATCH] Makefile.package.in: Makes it possible to override the default extract commands Allan W. Nielsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110516215226.26540f2a@surf \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.