From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: tap/bridge: Dropping NETIF_F_GSO/NETIF_F_SG Date: Tue, 17 May 2011 08:48:23 +0300 Message-ID: <20110517054823.GB26414@redhat.com> References: <20110516121857.GA4495@gondor.apana.org.au> <20110516224658.GA11157@gondor.apana.org.au> <20110516.190615.2121423692228640268.davem@davemloft.net> <20110516234538.GA11832@gondor.apana.org.au> <20110517051845.GA26414@redhat.com> <20110517052401.GA15198@gondor.apana.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: David Miller , mirqus@gmail.com, shanwei@cn.fujitsu.com, mirq-linux@rere.qmqm.pl, netdev@vger.kernel.org, bhutchings@solarflare.com To: Herbert Xu Return-path: Received: from mx1.redhat.com ([209.132.183.28]:60198 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751625Ab1EQFsZ (ORCPT ); Tue, 17 May 2011 01:48:25 -0400 Content-Disposition: inline In-Reply-To: <20110517052401.GA15198@gondor.apana.org.au> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, May 17, 2011 at 03:24:01PM +1000, Herbert Xu wrote: > On Tue, May 17, 2011 at 08:18:45AM +0300, Michael S. Tsirkin wrote: > > > > Hmm, we get the warnings about bits dropped on each set_offload > > call: > > netdev_update_features is called, > > that calls netdev_fix_features > > > > No? > > I presume this has changed recently as the current Linus tree > does not contain a call to netdev_update_features, it only calls > netdev_features_change. > > If so then this does ensure that the feature bits will be sane. > > I still think the warnings should be retained at their previous > level in the call paths other than set_offload. All we have to > do is add a parameter to netdev_update_features and co. > > Cheers, You mean like bool quiet? -- MST