From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH 08/31] nVMX: Fix local_vcpus_link handling
Date: Tue, 17 May 2011 11:42:57 -0300
Message-ID: <20110517144257.GA6622@amt.cnet>
References: <1305575004-nyh@il.ibm.com>
 <201105161948.p4GJm1as001742@rice.haifa.ibm.com>
 <20110517131918.GA3809@amt.cnet>
 <4DD27998.1040105@redhat.com>
 <20110517143532.GA2490@fermat.math.technion.ac.il>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Avi Kivity <avi@redhat.com>, kvm@vger.kernel.org, gleb@redhat.comqg
To: "Nadav Har'El" <nyh@math.technion.ac.il>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:1026 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755176Ab1EQOnI (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 17 May 2011 10:43:08 -0400
Content-Disposition: inline
In-Reply-To: <20110517143532.GA2490@fermat.math.technion.ac.il>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Tue, May 17, 2011 at 05:35:32PM +0300, Nadav Har'El wrote:
> On Tue, May 17, 2011, Avi Kivity wrote about "Re: [PATCH 08/31] nVMX: Fix local_vcpus_link handling":
> > static DEFINE_PER_CPU(struct list_head, vmcss_on_cpu);
> 
> This is an interesting suggestion. My initial plan was to do something similar
> to this, and I agree it could have been nicer code, but I had to change it
> after bumping into too many obstacles.
> 
> For example, currently, vmclear_local_vcpus() not only VMCLEARs the vmcss,
> it also sets vmx->vcpu.cpu = -1, xmv->launched=0 for the vcpus holding these
> VMCSs.  If we had only a list of VMCSs, how can we mark the vcpus as being not
> currently loaded (cpu=-1)?

Do it in vcpu_clear, its just an optimization not necessary in
vmclear_local_vcpus path.