All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Greg KH <gregkh@suse.de>
Cc: Stephen Warren <swarren@nvidia.com>,
	ldewangan@nvidia.com, linux-serial@vger.kernel.org,
	linux-tegra@vger.kernel.org
Subject: Re: [PATCH 0/2] tty/serial: Add PORT_TEGRA, fix break handling for it
Date: Tue, 17 May 2011 22:58:25 +0100	[thread overview]
Message-ID: <20110517225825.032e9461@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <20110517193836.GA6912@suse.de>

> If Alan acks these, I'll be glad to take them through the serial tree as
> normal, or you can take them through the tegra tree.
> 
> Either way, they need Alan's review first.

First one I am fine with. Second is more chip specific goop where we
don't want it. However right at the moment there isn't a magic cure to
that and the port->ops hackery I've been doing isn't done and it's not
reasonable to hold this up waiting for a project with indeterminate
completion date.

Ack #1

Can you add a 

/*
 * FIXME: This needs to become a port specific callback once we have a
 * framework for this
 */

to #2 so it doesn't get forgotten in a future cleanup.

Alan

      parent reply	other threads:[~2011-05-17 21:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-17 19:27 [PATCH 0/2] tty/serial: Add PORT_TEGRA, fix break handling for it Stephen Warren
     [not found] ` <1305660466-4704-1-git-send-email-swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2011-05-17 19:27   ` [PATCH 1/2] tty/serial: Add explicit PORT_TEGRA type Stephen Warren
2011-05-17 19:27   ` [PATCH 2/2] tty/serial: Fix break handling for PORT_TEGRA Stephen Warren
2011-05-17 19:38 ` [PATCH 0/2] tty/serial: Add PORT_TEGRA, fix break handling for it Greg KH
     [not found]   ` <20110517193836.GA6912-l3A5Bk7waGM@public.gmane.org>
2011-05-17 19:44     ` Stephen Warren
2011-05-17 21:58   ` Alan Cox [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110517225825.032e9461@lxorguk.ukuu.org.uk \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=gregkh@suse.de \
    --cc=ldewangan@nvidia.com \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=swarren@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.