From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Chinner Subject: Re: xfstests: device busy when umount Date: Wed, 18 May 2011 16:31:53 +1000 Message-ID: <20110518063153.GZ19446@dastard> References: <4DD286E5.8090105@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Eric Sandeen , Yongqiang Yang , Ext4 Developers List , xfs-oss To: Amir Goldstein Return-path: Received: from ipmail06.adl6.internode.on.net ([150.101.137.145]:29005 "EHLO ipmail06.adl6.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753733Ab1ERGc0 (ORCPT ); Wed, 18 May 2011 02:32:26 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-ext4-owner@vger.kernel.org List-ID: On Tue, May 17, 2011 at 06:01:14PM +0300, Amir Goldstein wrote: > On Tue, May 17, 2011 at 5:32 PM, Eric Sandeen wr= ote: > > On 5/17/11 4:03 AM, Yongqiang Yang wrote: > >> Hi, > >> > >> I noticed that all tests which contain 'device busy' errors have > >> falloc operations. =A0Does the error have something to do with fal= loc? Perhaps a bit more detail about what you are testing, how you've set up xfstests, etc, and some analysis of the problem is in order first? > > cc'ing xfs list since xfs devs maintain xfstests. > > > > What tests have "device busy" errors? =A0What do the usual investig= ative > > steps such as "lsof" and "fuser" tell you when this happens? >=20 > I tried running lsof | grep $TEST_DIR before umount > and I tried sleep 1 before umount and it didn't yield anything. Which usually indicates that you've got some kind of reference counting problem preventing the filesystem from being unmounted. > > Are there loop devices that didn't get cleaned up, or processes tha= t > > have not terminated? > > > > What tests have these problems? >=20 > for me 124 always fails to umount, and 198 and 213 sometimes fails to= umount. What, exactly, are you testing on? test 124 uses XFS_IOC_RESVSP directly, not fallocate(), so all it is doing on a non-XFS filesystem is iterating a loop that writes a 1MB file, reads it back then unlinks it.... Cheers, Dave. --=20 Dave Chinner david@fromorbit.com -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id p4I6WSx6223920 for ; Wed, 18 May 2011 01:32:28 -0500 Received: from ipmail06.adl6.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id F173B1341C2A for ; Tue, 17 May 2011 23:32:26 -0700 (PDT) Received: from ipmail06.adl6.internode.on.net (ipmail06.adl6.internode.on.net [150.101.137.145]) by cuda.sgi.com with ESMTP id SNRoejwunhN9I7Ag for ; Tue, 17 May 2011 23:32:26 -0700 (PDT) Date: Wed, 18 May 2011 16:31:53 +1000 From: Dave Chinner Subject: Re: xfstests: device busy when umount Message-ID: <20110518063153.GZ19446@dastard> References: <4DD286E5.8090105@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Amir Goldstein Cc: Eric Sandeen , Ext4 Developers List , Yongqiang Yang , xfs-oss On Tue, May 17, 2011 at 06:01:14PM +0300, Amir Goldstein wrote: > On Tue, May 17, 2011 at 5:32 PM, Eric Sandeen wrote: > > On 5/17/11 4:03 AM, Yongqiang Yang wrote: > >> Hi, > >> > >> I noticed that all tests which contain 'device busy' errors have > >> falloc operations. =A0Does the error have something to do with falloc? Perhaps a bit more detail about what you are testing, how you've set up xfstests, etc, and some analysis of the problem is in order first? > > cc'ing xfs list since xfs devs maintain xfstests. > > > > What tests have "device busy" errors? =A0What do the usual investigative > > steps such as "lsof" and "fuser" tell you when this happens? > = > I tried running lsof | grep $TEST_DIR before umount > and I tried sleep 1 before umount and it didn't yield anything. Which usually indicates that you've got some kind of reference counting problem preventing the filesystem from being unmounted. > > Are there loop devices that didn't get cleaned up, or processes that > > have not terminated? > > > > What tests have these problems? > = > for me 124 always fails to umount, and 198 and 213 sometimes fails to umo= unt. What, exactly, are you testing on? test 124 uses XFS_IOC_RESVSP directly, not fallocate(), so all it is doing on a non-XFS filesystem is iterating a loop that writes a 1MB file, reads it back then unlinks it.... Cheers, Dave. -- = Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs