From: Christoph Hellwig <hch@infradead.org>
To: Jan Kara <jack@suse.cz>
Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
Al Viro <viro@ZenIV.linux.org.uk>,
tytso@mit.edu, Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH 1/3] fs: Create __block_page_mkwrite() helper passing error values back
Date: Wed, 18 May 2011 14:07:36 -0400 [thread overview]
Message-ID: <20110518180736.GA10163@infradead.org> (raw)
In-Reply-To: <1305731882-8334-2-git-send-email-jack@suse.cz>
On Wed, May 18, 2011 at 05:18:00PM +0200, Jan Kara wrote:
> Create __block_page_mkwrite() helper which does all what block_page_mkwrite()
> does except that it passes back errors from __block_write_begin /
> block_commit_write calls.
Looks good to me. Long term I wonder wether we should force
->page_mkwrite to always return the page locked and just use normal
errnos all the way up to do_wp_page, but that can be left for a later
iteration as it would be quite invasive.
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2011-05-18 18:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-18 15:17 [PATCH 0/3] Make block_page_mkwrite() handle frozen fs (V2) Jan Kara
2011-05-18 15:18 ` [PATCH 1/3] fs: Create __block_page_mkwrite() helper passing error values back Jan Kara
2011-05-18 18:07 ` Christoph Hellwig [this message]
2011-05-18 15:18 ` [PATCH 2/3] vfs: Block mmapped writes while the fs is frozen Jan Kara
2011-05-18 18:12 ` Christoph Hellwig
2011-05-19 12:08 ` Jan Kara
2011-05-18 15:18 ` [PATCH 3/3] ext4: Rewrite ext4_page_mkwrite() to return locked page Jan Kara
2011-05-18 18:00 ` [PATCH 0/3] Make block_page_mkwrite() handle frozen fs (V2) Darrick J. Wong
2011-05-19 10:57 ` Jan Kara
2011-05-20 17:59 ` Ted Ts'o
2011-05-23 13:21 ` Jan Kara
2011-05-23 14:47 ` Ted Ts'o
2011-05-19 12:30 ` Jan Kara
2011-05-19 16:34 ` Darrick J. Wong
2011-05-18 18:13 ` Christoph Hellwig
2011-05-19 12:24 ` Jan Kara
-- strict thread matches above, loose matches on Subject: below --
2011-05-10 22:29 [PATCH 0/3] Rewrite ext4_page_mkwrite, fix fs freezing Jan Kara
2011-05-10 22:29 ` [PATCH 1/3] fs: Create __block_page_mkwrite() helper passing error values back Jan Kara
2011-05-17 15:09 ` Christoph Hellwig
2011-05-18 7:35 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110518180736.GA10163@infradead.org \
--to=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.