All of lore.kernel.org
 help / color / mirror / Atom feed
From: dave.martin@linaro.org (Dave Martin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] ARM: thumb: Have the machine name indicate operation in thumb mode.
Date: Thu, 19 May 2011 09:36:58 +0100	[thread overview]
Message-ID: <20110519083658.GA2431@arm.com> (raw)
In-Reply-To: <20110518223319.GB21384@n2100.arm.linux.org.uk>

On Wed, May 18, 2011 at 11:33:19PM +0100, Russell King - ARM Linux wrote:

[...]

> We already have a way of adding stuff for bug tracking purposes.  The
> "Internal error" line is perpended with 'PREEMPT' or 'SMP' depending
> on what build options were enabled.  We just need to do the same with
> T2.  IOW, something like this:
> 
> diff --git a/arch/arm/kernel/traps.c b/arch/arm/kernel/traps.c
> index 3b54ad1..78d7714 100644
> --- a/arch/arm/kernel/traps.c
> +++ b/arch/arm/kernel/traps.c
> @@ -225,6 +225,11 @@ void show_stack(struct task_struct *tsk, unsigned long *sp)
>  #else
>  #define S_SMP ""
>  #endif
> +#ifdef CONFIG_THUMB2_KERNEL
> +#define S_ISA " T2"

Just for consistency, can I suggest that if this is implemented, we
make the string " thumb2"? (upper case optional)  This matches what
we now put in MODULE_ARCH_VERMAGIC, as well as being closer to the
CONFIG_ name.

Cheers
---Dave

  parent reply	other threads:[~2011-05-19  8:36 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-13 19:53 [PATCH 1/1] ARM: thumb: Have the machine name indicate operation in thumb mode Vadim Bendebury
2011-05-14  9:59 ` Catalin Marinas
2011-05-14 10:02   ` Russell King - ARM Linux
2011-05-16 12:16     ` Dave Martin
2011-05-16 14:32       ` Nicolas Pitre
2011-05-16 14:43         ` Dave Martin
2011-05-18 20:59           ` Vadim Bendebury (вб)
2011-05-18 22:27             ` Nicolas Pitre
2011-05-18 22:33               ` Russell King - ARM Linux
2011-05-18 22:49                 ` Nicolas Pitre
2011-05-18 22:57                   ` Russell King - ARM Linux
     [not found]                     ` <BANLkTinS4XR-QrCsmhStROxkJEy1-PwCTA@mail.gmail.com>
2011-05-26 13:01                       ` Russell King - ARM Linux
2011-05-26 13:56                         ` Dave Martin
2011-05-26 13:59                           ` Russell King - ARM Linux
2011-05-19  8:36                 ` Dave Martin [this message]
  -- strict thread matches above, loose matches on Subject: below --
2011-05-12  0:31 Vadim Bendebury

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110519083658.GA2431@arm.com \
    --to=dave.martin@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.