All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
To: Lars Michael <lh_post-/E1597aS9LQAvxtiuMwx3w@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: How to use one I2C device from two modules?
Date: Fri, 20 May 2011 10:07:19 +0200	[thread overview]
Message-ID: <20110520100719.4107397a@endymion.delvare> (raw)
In-Reply-To: <184526.31465.qm-hgS9n0fW3jyvuULXzWHTWIglqE1Y4D90QQ4Iyu8u01E@public.gmane.org>

Hi Lars,

On Mon, 16 May 2011 01:10:22 -0700 (PDT), Lars Michael wrote:
> --- On Fri, 13/5/11, Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org> wrote:
> > No, this doesn't seem right. A given system may have more
> > than one PCA950x chip. And symbol dependencies are a hell
> > to handle as soon as things get more complex. Such an export
> > will never be accepted upstream.
> 
> You are right, and this quick solution was not meant to be submitted.
>  
> > I can think of 2 ways to handle your problem.
> > 
> > If neither works for you for whatever reason, maybe we can
> > add a helper function to i2c-core to retrieve an i2c_client
> > by bus number and address. Maybe others would find it useful
> > as well.
> 
> I was looking for such a function, it could be very handy. And btw
> a get adapter by id already exists. 

This function could certainly be added if someone ever really needs it.
But in your case, it seems better to write a proper gpio driver for your
device and then have your subdrivers cleanly request the GPIO pins they
need. And you don't need to access the i2c_client from the subdrivers
if you do this.

-- 
Jean Delvare

      parent reply	other threads:[~2011-05-20  8:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-06 11:30 How to use one I2C device from two modules? Lars Michael
     [not found] ` <842687.69100.qm-sMamaaD5nQOvuULXzWHTWIglqE1Y4D90QQ4Iyu8u01E@public.gmane.org>
2011-05-07 13:28   ` Jean Delvare
     [not found]     ` <20110507152832.25276ac6-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2011-05-13  7:47       ` Lars Michael
     [not found]         ` <135179.26946.qm-XzixtO+UlYSvuULXzWHTWIglqE1Y4D90QQ4Iyu8u01E@public.gmane.org>
2011-05-13  8:46           ` Jean Delvare
     [not found]             ` <20110513104650.3d1b3ea6-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2011-05-16  8:10               ` Lars Michael
     [not found]                 ` <184526.31465.qm-hgS9n0fW3jyvuULXzWHTWIglqE1Y4D90QQ4Iyu8u01E@public.gmane.org>
2011-05-20  8:07                   ` Jean Delvare [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110520100719.4107397a@endymion.delvare \
    --to=khali-puyad+kwke1g9huczpvpmw@public.gmane.org \
    --cc=lh_post-/E1597aS9LQAvxtiuMwx3w@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.