From: pavel@ucw.cz (Pavel Machek)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] MAX1111: Fix race condition causing NULL pointer exception
Date: Sat, 21 May 2011 22:28:07 +0200 [thread overview]
Message-ID: <20110521202806.GA3518@elf.ucw.cz> (raw)
In-Reply-To: <201105200013.20380.morpheus.ibis@gmail.com>
Hi!
> > I think you want to hold the mutex at the point you setup the data to be
> > transferred, do the transfer, and then release the mutex once you've read
> > the results of the transfer.
>
> oh no, not again...
> this was the earliest version, not the cleaned-up one (notice the lock in
> setup-transfer, which I said was unnecessary)
> here is the cleaner (newest) version:
Unfortunately that one does not apply, due to
> @@ -213,6 +224,7 @@ static int __devexit max1111_remove(struct spi_device
> *spi)
Whitespace damage. (but if you just delete this extra newline, its
fine).
Other than that, it seems to work. I was playing with max1111 a lot
today, and no oops.
ACK.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2011-05-21 20:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-18 15:18 [PATCH] MAX1111: Fix race condition causing NULL pointer exception Pavel Herrmann
2011-05-18 15:29 ` Eric Miao
2011-05-18 15:29 ` Russell King - ARM Linux
2011-05-18 17:36 ` Marek Vasut
2011-05-18 22:47 ` Russell King - ARM Linux
2011-05-19 12:35 ` Pavel Machek
2011-05-19 12:51 ` Pavel Herrmann
2011-05-19 13:55 ` Marek Vasut
2011-05-19 19:31 ` Russell King - ARM Linux
2011-05-19 22:13 ` Pavel Herrmann
2011-05-20 21:20 ` Russell King - ARM Linux
2011-05-21 20:28 ` Pavel Machek [this message]
2011-05-21 20:45 ` Pavel Herrmann
2011-05-22 15:52 ` Marek Vasut
2011-05-18 21:47 ` Cyril Hrubis
2011-06-30 12:36 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110521202806.GA3518@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.