From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH] cifs: mark CONFIG_CIFS_NFSD_EXPORT as BROKEN Date: Sun, 22 May 2011 07:59:38 -0400 Message-ID: <20110522115938.GA27941@infradead.org> References: <1306065324-24604-1-git-send-email-jlayton@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jeff Layton Return-path: Content-Disposition: inline In-Reply-To: <1306065324-24604-1-git-send-email-jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Sender: linux-cifs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: On Sun, May 22, 2011 at 07:55:24AM -0400, Jeff Layton wrote: > This will never work properly with CIFS, as the protocol has no ability > whatsoever for looking up files by filehandle. It *might* be possible to > eventually do this with SMB2, but that remains to be seen. > > For now, it just plain doesn't work. Mark it BROKEN to discourage > distros from enabling it. It's actually dead code at this point - fs/nfsd/vfs.c:check_export() refuses to export a filesystem that does not have a fh_to_dentry operation, which cifs doesn't provide. IMHO it's best to just remove the option and all surrounding code.