From: Szabolcs Nagy <nsz@port70.net>
To: dash@vger.kernel.org
Subject: build issues when using pcc
Date: Sun, 22 May 2011 14:34:14 +0200 [thread overview]
Message-ID: <20110522123414.GD6142@port70.net> (raw)
hello i compiled dash with pcc and found two issues:
src/output.h the outc macro is not standard c:
#define outc(c, file)<->((file)->nextc == (file)->end ? outcslow((c), (file)) : (*(file)->nextc = (c), (file)->nextc++))
type signature of the operands are int ? void : char*
but the two sides of : should be compatible
either use
... ? outcslow(), 0 : ...
or
... ? outcslow() : ..., (void)0
otherwise a standard compliant compiler won't compile it
the other issue is in the mkbuiltins:
it assumes that the cpp does not produce empty lines with
whitespace only
the following line
< $builtins sed '/^#/d; /^$/d' > $temp
should be
< $builtins sed '/^#/d; /^ *$/d' > $temp
so empty lines with spaces are dropped as well
(allowed by the standard after the preprocessing pass)
(also it would be nice to include a configure script in
the git repo, or don't use autoconf in the first place)
next reply other threads:[~2011-05-22 12:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-22 12:34 Szabolcs Nagy [this message]
2011-05-22 16:46 ` build issues when using pcc Jonathan Nieder
[not found] ` <20110522173900.GG6142@port70.net>
2011-05-22 17:41 ` Jonathan Nieder
2011-07-07 7:22 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110522123414.GD6142@port70.net \
--to=nsz@port70.net \
--cc=dash@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.