Re: [PATCH] net: ipv4: add IPPROTO_ICMP socket kind

[Vasiliy Kulikov <segoon@openwall.com>]

On Sun, May 22, 2011 at 18:01 +0200, Pavel Kankovsky wrote:
> On Thu, 14 Apr 2011, Alexey Dobriyan wrote:
> 
> > Also, there was big discussion re exposing kernel socket pointers,
> > which this file continue to do.
> 
> One late comment:
> 
> The code was intented to immitate /proc/net/udp.
> 
> As far as I can tell UDP and TCP (having checked udp.c and tcp_ipv[46].c
> in the latest net-next-2.6) do not have any qualms about exposing kernel
> pointers so we are a little bit holier than the pope here. :)

Anyway, ping uses %pK:

   seq_printf(f, "%5d: %08X:%04X %08X:%04X"
           " %02X %08X:%08X %02X:%08lX %08X %5d %8d %lu %d %pK d%n",
           bucket, src, srcp, dest, destp, sp->sk_state,
           sk_wmem_alloc_get(sp),
           sk_rmem_alloc_get(sp),
           0, 0L, 0, sock_i_uid(sp), 0, sock_i_ino(sp),
           atomic_read(&sp->sk_refcnt), sp,
           atomic_read(&sp->sk_drops), len);

Thanks,

-- 
Vasiliy Kulikov
http://www.openwall.com - bringing security into open computing environments