diff for duplicates of <20110523043711.GA4890@ericsson.com> diff --git a/a/1.txt b/N1/1.txt index 12c2e5d..528d2ea 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -151,8 +151,8 @@ Same here (variable name). > } > } > + } else -> + if (man_id = 0xA1) { /* NXP Semiconductor/Philips */ -> + if (chip_id = 0x00 +> + if (man_id == 0xA1) { /* NXP Semiconductor/Philips */ +> + if (chip_id == 0x00 > + && address >= 0x48 && address <= 0x4F) { This multi-line split is unnecessary. @@ -190,8 +190,3 @@ In addition to the above, your patch generates several checkpatch errors Thanks, Guenter - -_______________________________________________ -lm-sensors mailing list -lm-sensors@lm-sensors.org -http://lists.lm-sensors.org/mailman/listinfo/lm-sensors diff --git a/a/content_digest b/N1/content_digest index d0e363c..daab528 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\01305814253-12528-1-git-send-email-sdevrien@cisco.com\0" "From\0Guenter Roeck <guenter.roeck@ericsson.com>\0" - "Subject\0Re: [lm-sensors] [PATCH] Add support for the Philips SA56004\0" - "Date\0Mon, 23 May 2011 04:37:11 +0000\0" + "Subject\0Re: [lm-sensors] [PATCH] Add support for the Philips SA56004 temperature sensor.\0" + "Date\0Sun, 22 May 2011 21:37:11 -0700\0" "To\0sdevrien@cisco.com <sdevrien@cisco.com>\0" "Cc\0khali@linux-fr.org <khali@linux-fr.org>" lm-sensors@lm-sensors.org <lm-sensors@lm-sensors.org> @@ -161,8 +161,8 @@ "> \t\t\t}\n" "> \t\t}\n" "> +\t} else\n" - "> +\tif (man_id = 0xA1) { /* NXP Semiconductor/Philips */\n" - "> +\t\tif (chip_id = 0x00\n" + "> +\tif (man_id == 0xA1) { /* NXP Semiconductor/Philips */\n" + "> +\t\tif (chip_id == 0x00\n" "> +\t\t && address >= 0x48 && address <= 0x4F) {\n" "\n" "This multi-line split is unnecessary.\n" @@ -199,11 +199,6 @@ "(trailing whitespace). Please fix.\n" "\n" "Thanks,\n" - "Guenter\n" - "\n" - "_______________________________________________\n" - "lm-sensors mailing list\n" - "lm-sensors@lm-sensors.org\n" - http://lists.lm-sensors.org/mailman/listinfo/lm-sensors + Guenter -0d8c71f12bf3e0bbfd313da3197783d1148189a235f2c65677c0c90d819da7a3 +624469e1166caf957e77a3da90be2da7fe564b98ec87c230b0d79b3791ff51f5
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.