All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH 3/6] ktest: Reboot to good kernel after every bisect run
Date: Mon, 23 May 2011 09:51:23 -0400	[thread overview]
Message-ID: <20110523135314.896139545@goodmis.org> (raw)
In-Reply-To: 20110523135120.309567301@goodmis.org

[-- Attachment #1: 0003-ktest-Reboot-to-good-kernel-after-every-bisect-run.patch --]
[-- Type: text/plain, Size: 972 bytes --]

From: Steven Rostedt <srostedt@redhat.com>

Reboot after each bisect run regardless if the bisect passed
or failed. The test may just be to boot the kernel and that kernel
may not have a way to copy the next kerne to it. Reboot to a known
good kernel after each bisect run.

Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
 tools/testing/ktest/ktest.pl |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/tools/testing/ktest/ktest.pl b/tools/testing/ktest/ktest.pl
index 0603e64..2011222 100755
--- a/tools/testing/ktest/ktest.pl
+++ b/tools/testing/ktest/ktest.pl
@@ -1248,14 +1248,14 @@ sub run_bisect_test {
 
     if ($failed) {
 	$result = 0;
-
-	# reboot the box to a good kernel
-	if ($type ne "build") {
-	    bisect_reboot;
-	}
     } else {
 	$result = 1;
     }
+
+    # reboot the box to a kernel we can ssh to
+    if ($type ne "build") {
+	bisect_reboot;
+    }
     $in_bisect = 0;
 
     return $result;
-- 
1.7.4.4



  parent reply	other threads:[~2011-05-23 13:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-23 13:51 [PATCH 0/6] ktest: Updates for ktest.pl Steven Rostedt
2011-05-23 13:51 ` [PATCH 1/6] ktest: Fix post install command Steven Rostedt
2011-05-23 13:51 ` [PATCH 2/6] ktest: If test failed due to timeout, print that Steven Rostedt
2011-05-23 13:51 ` Steven Rostedt [this message]
2011-05-23 15:04   ` [PATCH 3/6] ktest: Reboot to good kernel after every bisect run John Kacur
2011-05-23 15:18     ` Steven Rostedt
2011-05-23 13:51 ` [PATCH 4/6] ktest: Reboot after each patchcheck run Steven Rostedt
2011-05-23 13:51 ` [PATCH 5/6] ktest: Create variables for the ktest config files Steven Rostedt
2011-05-23 13:51 ` [PATCH 6/6] ktest: Allow options to be used by other options Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110523135314.896139545@goodmis.org \
    --to=rostedt@goodmis.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.