From: Hans Petter Selasky <hselasky@c2i.net>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
Mauro Carvalho Chehab <mchehab@redhat.com>
Subject: Re: [PATCH] Make code more readable by not using the return value of the WARN() macro. Set ret variable in an undefined case.
Date: Mon, 23 May 2011 21:04:08 +0200 [thread overview]
Message-ID: <201105232104.08895.hselasky@c2i.net> (raw)
In-Reply-To: <Pine.LNX.4.64.1105232019560.30305@axis700.grange>
On Monday 23 May 2011 20:22:02 Guennadi Liakhovetski wrote:
> Please, inline patches. Otherwise, this is what one gets, when replying.
>
> On Mon, 23 May 2011, Hans Petter Selasky wrote:
> > --HPS
>
> In any case, just throwing in my 2 cents - no idea how not using the
> return value of WARN() makes code more readable. On the contrary, using it
> is a standard practice. This patch doesn't seem like an improvement to me.
There is no strong reason for the WARN() part, you may ignore that, but the
ret = 0, part is still valid. Should I generate a new patch or can you handle
this?
--HPS
next prev parent reply other threads:[~2011-05-23 19:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-23 11:07 [PATCH] Make code more readable by not using the return value of the WARN() macro. Set ret variable in an undefined case Hans Petter Selasky
2011-05-23 18:22 ` Guennadi Liakhovetski
2011-05-23 19:04 ` Hans Petter Selasky [this message]
2011-05-26 0:03 ` Mauro Carvalho Chehab
2011-05-26 6:21 ` Guennadi Liakhovetski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201105232104.08895.hselasky@c2i.net \
--to=hselasky@c2i.net \
--cc=g.liakhovetski@gmx.de \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.