From: plagnioj@jcrosoft.com (Jean-Christophe PLAGNIOL-VILLARD)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4] davinci: dm646x: remove the macros from the header to move to c file
Date: Tue, 24 May 2011 07:32:20 +0200 [thread overview]
Message-ID: <20110524053220.GD863@game.jcrosoft.org> (raw)
In-Reply-To: <B85A65D85D7EB246BE421B3FB0FBB593024D09B3A7@dbde02.ent.ti.com>
On 19:04 Mon 23 May , Nori, Sekhar wrote:
>
> Hi Jean-Christophe,
>
> On Fri, May 20, 2011 at 19:54:01, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > On 19:42 Fri 20 May , Manjunath Hadli wrote:
> > > move the register base addresses and offsets used only by dm646x
> > > platform file from platform header dm646x.h to dm646x.c as they
> > > are used only in the c file.
> > >
> > > Signed-off-by: Manjunath Hadli <manjunath.hadli@ti.com>
> > I do not think it's a good idea to put the register mapping in the c file
> > evenif they are used only today in dm646x
> >
>
> Unless a definition is used across C files, it would be better to
> keep it local to the C file. Why treat base addresses and register
> offsets differently?
no difference the macro are nearly every time put in header not in C code
ditto of ifdef
Best Regards,
J.
next prev parent reply other threads:[~2011-05-24 5:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-20 14:12 [PATCH 3/4] davinci: dm646x: remove the macros from the header to move to c file Manjunath Hadli
2011-05-20 14:24 ` Jean-Christophe PLAGNIOL-VILLARD
2011-05-23 13:34 ` Nori, Sekhar
2011-05-24 5:32 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2011-05-24 10:54 ` Nori, Sekhar
2011-05-20 15:11 ` Sergei Shtylyov
2011-05-23 14:17 ` Nori, Sekhar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110524053220.GD863@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.