All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Suresh Siddha <suresh.b.siddha@intel.com>,
	Daniel J Blueman <daniel.blueman@gmail.com>
Subject: Re: [GIT PULL] more x86/apic changes for v2.6.40
Date: Tue, 24 May 2011 08:15:25 +0200	[thread overview]
Message-ID: <20110524061525.GA29815@elte.hu> (raw)
In-Reply-To: <20110524060321.GA20904@elte.hu>


* Ingo Molnar <mingo@elte.hu> wrote:

> Possibly the resume fix in the APIC merge :-/
> 
> It's these commits:
> 
>  31dce14a3269: x86, ioapic: Use ioapic_saved_data while enabling intr-remapping
>  4c79185cdb14: x86, ioapic: Allocate ioapic_saved_data early
>  b64ce24daffb: x86, ioapic: Fix potential resume deadlock
> 
> The first one fixes the resume bug in an easily backportable way (although 
> the GFP_ATOMIC is not nice), the later two do it cleaner.
> 
> So if b64ce24daffb works for you and 31dce14a3269 breaks this would signal 
> that the fix from Suresh is the source of the Atom regression.

In particular the lapic_resume() bit looks suspect. Does save_ioapic_entries() 
get called? It's called in enable_IR_x2apic() but your Atom is probably not 
x2apic. Non-x2apic system do not get save_ioapic_entries() called, so there's 
nothing to restore at resume time AFAICS ... Suresh?

Thanks,

	Ingo

  parent reply	other threads:[~2011-05-24  6:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-23 19:30 [GIT PULL] more x86/apic changes for v2.6.40 Ingo Molnar
2011-05-24  5:58 ` Linus Torvalds
2011-05-24  6:03   ` Ingo Molnar
2011-05-24  6:09     ` Linus Torvalds
2011-05-24  6:15     ` Ingo Molnar [this message]
2011-05-24 17:45       ` Suresh Siddha
2011-05-24 18:34         ` Linus Torvalds
2011-05-24 18:37           ` Ingo Molnar
2011-05-24 18:36         ` [conditional GIT PULL] x86 fixes Ingo Molnar
2011-05-24 18:50           ` Linus Torvalds
2011-05-24 19:25         ` [tip:x86/urgent] x86, ioapic: Restore ioapic entries during resume properly tip-bot for Suresh Siddha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110524061525.GA29815@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@linux-foundation.org \
    --cc=daniel.blueman@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=suresh.b.siddha@intel.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.