All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 1/3 v2] sh_mobile_meram: Add clock enable/disble hooks via runtime PM
Date: Tue, 24 May 2011 07:37:08 +0000	[thread overview]
Message-ID: <20110524073707.GH11986@linux-sh.org> (raw)
In-Reply-To: <1306221381-30083-2-git-send-email-dhobsong@igel.co.jp>

On Tue, May 24, 2011 at 04:16:19PM +0900, Damian Hobson-Garcia wrote:
> @@ -460,11 +461,33 @@ static int sh_mobile_meram_update(struct sh_mobile_meram_info *pdata,
> +int sh_mobile_meram_clk_on(struct sh_mobile_meram_info *pdata)
> +int sh_mobile_meram_clk_off(struct sh_mobile_meram_info *pdata)

[snip]

>  	.meram_update		= sh_mobile_meram_update,
> +	.meram_clk_off		= sh_mobile_meram_clk_off,
> +	.meram_clk_on		= sh_mobile_meram_clk_on,
>  };
>  
Seems like the _clk_off/on functions ought to be static, too.

      reply	other threads:[~2011-05-24  7:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-24  7:16 [PATCH 1/3 v2] sh_mobile_meram: Add clock enable/disble hooks via runtime PM Damian Hobson-Garcia
2011-05-24  7:37 ` Paul Mundt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110524073707.GH11986@linux-sh.org \
    --to=lethal@linux-sh.org \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.