From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King Subject: Re: [PATCH -next] mtd: fix physmap.h warnings Date: Tue, 24 May 2011 08:40:20 +0100 Message-ID: <20110524074020.GA9490@flint.arm.linux.org.uk> References: <20110523154518.5e27cfb0.sfr@canb.auug.org.au> <20110523113709.4357b4ba.randy.dunlap@oracle.com> <1306216431.2785.46.camel@localhost> <1306216683.2785.47.camel@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from caramon.arm.linux.org.uk ([78.32.30.218]:59204 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753940Ab1EXHk5 (ORCPT ); Tue, 24 May 2011 03:40:57 -0400 Content-Disposition: inline In-Reply-To: <1306216683.2785.47.camel@localhost> Sender: linux-next-owner@vger.kernel.org List-ID: To: Artem Bityutskiy Cc: Stephen Rothwell , linux-mtd@lists.infradead.org, linux-next@vger.kernel.org, David Woodhouse , LKML , Marc Zyngier , Randy Dunlap On Tue, May 24, 2011 at 08:58:03AM +0300, Artem Bityutskiy wrote: > On Tue, 2011-05-24 at 08:53 +0300, Artem Bityutskiy wrote: > > On Mon, 2011-05-23 at 11:37 -0700, Randy Dunlap wrote: > > > From: Randy Dunlap > > > > > > Fix build warnings in physmap.h: > > > > > > include/linux/mtd/physmap.h:25: warning: 'struct platform_device' declared inside parameter list > > > include/linux/mtd/physmap.h:25: warning: its scope is only this definition or declaration, which is probably not what you want > > > include/linux/mtd/physmap.h:26: warning: 'struct platform_device' declared inside parameter list > > > include/linux/mtd/physmap.h:27: warning: 'struct platform_device' declared inside parameter list > > > > > > Signed-off-by: Randy Dunlap > > > > Oh, this was missed during review. This was introduced in > > b7281ca2a4b00044c60c25059f467d05772cdbe3 which is going in via Russel's > > tree, so I guess Russel could pick up your patch. > > My big apologies, s/Russel/Russell/. Which patch? Neither of these messages contained Randy's patch and I wasn't included on the original posting. -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [2002:4e20:1eda::1] (helo=caramon.arm.linux.org.uk) by canuck.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1QOmEX-0005wE-PM for linux-mtd@lists.infradead.org; Tue, 24 May 2011 07:40:55 +0000 Date: Tue, 24 May 2011 08:40:20 +0100 From: Russell King To: Artem Bityutskiy Subject: Re: [PATCH -next] mtd: fix physmap.h warnings Message-ID: <20110524074020.GA9490@flint.arm.linux.org.uk> References: <20110523154518.5e27cfb0.sfr@canb.auug.org.au> <20110523113709.4357b4ba.randy.dunlap@oracle.com> <1306216431.2785.46.camel@localhost> <1306216683.2785.47.camel@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1306216683.2785.47.camel@localhost> Sender: Russell King Cc: Randy Dunlap , Stephen Rothwell , Marc Zyngier , LKML , linux-next@vger.kernel.org, linux-mtd@lists.infradead.org, David Woodhouse List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, May 24, 2011 at 08:58:03AM +0300, Artem Bityutskiy wrote: > On Tue, 2011-05-24 at 08:53 +0300, Artem Bityutskiy wrote: > > On Mon, 2011-05-23 at 11:37 -0700, Randy Dunlap wrote: > > > From: Randy Dunlap > > > > > > Fix build warnings in physmap.h: > > > > > > include/linux/mtd/physmap.h:25: warning: 'struct platform_device' declared inside parameter list > > > include/linux/mtd/physmap.h:25: warning: its scope is only this definition or declaration, which is probably not what you want > > > include/linux/mtd/physmap.h:26: warning: 'struct platform_device' declared inside parameter list > > > include/linux/mtd/physmap.h:27: warning: 'struct platform_device' declared inside parameter list > > > > > > Signed-off-by: Randy Dunlap > > > > Oh, this was missed during review. This was introduced in > > b7281ca2a4b00044c60c25059f467d05772cdbe3 which is going in via Russel's > > tree, so I guess Russel could pick up your patch. > > My big apologies, s/Russel/Russell/. Which patch? Neither of these messages contained Randy's patch and I wasn't included on the original posting. -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: