From: Ville Tervo <ville.tervo@nokia.com>
To: ext Jaikumar Ganesh <jaikumar@google.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: Add BT_POWER L2CAP socket option.
Date: Tue, 24 May 2011 11:37:23 +0300 [thread overview]
Message-ID: <20110524083723.GB2480@null> (raw)
In-Reply-To: <1306199164-28310-1-git-send-email-jaikumar@google.com>
Hi Jaikumar,
On Mon, May 23, 2011 at 06:06:04PM -0700, ext Jaikumar Ganesh wrote:
> Add BT_POWER socket option used to control the power
> characteristics of the underlying ACL link. When the remote end
> has put the link in sniff mode and the host stack wants to send
> data we need need to explicitly exit sniff mode to work well with
> certain devices (For example, A2DP on Plantronics Voyager 855).
> However, this causes problems with HID devices.
>
> Hence, moving into active mode when sending data, irrespective
> of who set the sniff mode has been made as a socket option. By
> default, we will move into active mode. HID devices can set the
> L2CAP socket option to prevent this from happening.
>
I would prefer keeping old way the default way. Otherwise you need to update
all socket users in user space. Other that that this looks good to me.
--
Ville
next prev parent reply other threads:[~2011-05-24 8:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-24 1:06 [PATCH] Bluetooth: Add BT_POWER L2CAP socket option Jaikumar Ganesh
2011-05-24 8:37 ` Ville Tervo [this message]
2011-05-24 16:20 ` Luiz Augusto von Dentz
2011-05-24 16:44 ` Jaikumar Ganesh
2011-05-24 18:24 ` Luiz Augusto von Dentz
2011-05-25 1:07 ` Jaikumar Ganesh
2011-05-30 22:11 ` Gustavo F. Padovan
2011-06-01 1:53 ` Jaikumar Ganesh
2011-06-01 22:20 ` Gustavo F. Padovan
2011-06-02 1:18 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110524083723.GB2480@null \
--to=ville.tervo@nokia.com \
--cc=jaikumar@google.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.