From: Matthew Wilcox <matthew@wil.cx>
To: sdrb <sdrb@onet.eu>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: Semaphore should be released in get_super
Date: Tue, 24 May 2011 05:20:07 -0600 [thread overview]
Message-ID: <20110524112007.GD26392@parisc-linux.org> (raw)
In-Reply-To: <4DDB8317.7040300@onet.eu>
On Tue, May 24, 2011 at 12:06:15PM +0200, sdrb wrote:
> Hello,
>
> Probably I found a bug in get_super() proc. I think there should be
> semaphore released before return sb.
That's the point of get_super(). It's supposed to return with the
semaphore held. Users call drop_super() later which releases the
semaphore.
--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next prev parent reply other threads:[~2011-05-24 11:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-24 10:06 Semaphore should be released in get_super sdrb
2011-05-24 11:20 ` Matthew Wilcox [this message]
2011-05-24 12:04 ` sdrb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110524112007.GD26392@parisc-linux.org \
--to=matthew@wil.cx \
--cc=linux-fsdevel@vger.kernel.org \
--cc=sdrb@onet.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.