From: agk@sourceware.org <agk@sourceware.org>
To: lvm-devel@redhat.com
Subject: LVM2 ./WHATS_NEW lib/config/config.c lib/devic ...
Date: 24 May 2011 13:36:59 -0000 [thread overview]
Message-ID: <20110524133659.32272.qmail@sourceware.org> (raw)
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: agk at sourceware.org 2011-05-24 13:36:58
Modified files:
. : WHATS_NEW
lib/config : config.c
lib/device : dev-io.c device.h
lib/filters : filter.c
Log message:
Add and use dev_open_readonly and variations.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1990&r2=1.1991
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/config/config.c.diff?cvsroot=lvm2&r1=1.91&r2=1.92
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/device/dev-io.c.diff?cvsroot=lvm2&r1=1.76&r2=1.77
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/device/device.h.diff?cvsroot=lvm2&r1=1.48&r2=1.49
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/filters/filter.c.diff?cvsroot=lvm2&r1=1.61&r2=1.62
--- LVM2/WHATS_NEW 2011/05/19 13:59:23 1.1990
+++ LVM2/WHATS_NEW 2011/05/24 13:36:57 1.1991
@@ -1,5 +1,6 @@
Version 2.02.86 -
=================================
+ Add and use dev_open_readonly and variations.
Do not log a superfluous stack message when the lv is properly processed.
Do not issue an error message when unable to remove .cache on read-only fs.
Avoid memlock size mismatch by preallocating stdio line buffers.
--- LVM2/lib/config/config.c 2011/03/10 14:51:35 1.91
+++ LVM2/lib/config/config.c 2011/05/24 13:36:57 1.92
@@ -295,7 +295,7 @@
if (!(c->dev = dev_create_file(c->filename, NULL, NULL, 1)))
return_0;
- if (!dev_open_flags(c->dev, O_RDONLY, 0, 0)) {
+ if (!dev_open_readonly_buffered(c->dev)) {
c->dev = 0;
return_0;
}
--- LVM2/lib/device/dev-io.c 2011/04/12 21:59:01 1.76
+++ LVM2/lib/device/dev-io.c 2011/05/24 13:36:57 1.77
@@ -556,6 +556,21 @@
return dev_open_flags(dev, flags, 1, 0);
}
+int dev_open_readonly(struct device *dev)
+{
+ return dev_open_flags(dev, O_RDONLY, 1, 0);
+}
+
+int dev_open_readonly_buffered(struct device *dev)
+{
+ return dev_open_flags(dev, O_RDONLY, 0, 0);
+}
+
+int dev_open_readonly_quiet(struct device *dev)
+{
+ return dev_open_flags(dev, O_RDONLY, 1, 1);
+}
+
int dev_test_excl(struct device *dev)
{
int flags;
--- LVM2/lib/device/device.h 2011/04/12 21:59:01 1.48
+++ LVM2/lib/device/device.h 2011/05/24 13:36:57 1.49
@@ -74,6 +74,9 @@
int dev_open(struct device *dev);
int dev_open_quiet(struct device *dev);
int dev_open_flags(struct device *dev, int flags, int direct, int quiet);
+int dev_open_readonly(struct device *dev);
+int dev_open_readonly_buffered(struct device *dev);
+int dev_open_readonly_quiet(struct device *dev);
int dev_close(struct device *dev);
int dev_close_immediate(struct device *dev);
void dev_close_all(void);
--- LVM2/lib/filters/filter.c 2011/02/18 14:11:23 1.61
+++ LVM2/lib/filters/filter.c 2011/05/24 13:36:58 1.62
@@ -147,7 +147,7 @@
}
/* Check it's accessible */
- if (!dev_open_flags(dev, O_RDONLY, 1, 1)) {
+ if (!dev_open_readonly_quiet(dev)) {
log_debug("%s: Skipping: open failed", name);
return 0;
}
reply other threads:[~2011-05-24 13:36 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110524133659.32272.qmail@sourceware.org \
--to=agk@sourceware.org \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.