From: Ted Ts'o <tytso@mit.edu>
To: Yongqiang Yang <xiaoqiangnk@gmail.com>
Cc: linux-ext4@vger.kernel.org, lczerner@redhat.com, amir73il@gmail.com
Subject: Re: [PATCH v4] ext4:Let ext4_ext_fiemap_cb() handle blocks before request range correctly.
Date: Tue, 24 May 2011 11:42:12 -0400 [thread overview]
Message-ID: <20110524154212.GA26055@thunk.org> (raw)
In-Reply-To: <1306134178-9883-1-git-send-email-xiaoqiangnk@gmail.com>
On Mon, May 23, 2011 at 03:02:58PM +0800, Yongqiang Yang wrote:
> To get delayed-extent information, ext4_ext_fiemap_cb() looks up
> pagecache, it thus collects information starting from a page's
> head block.
>
> If blocksize < pagesize, the beginning blocks of a page may lies
> before the request range. So ext4_ext_fiemap_cb() should proceed
> ignoring them, because they has been handled before. If no mapped
> buffer in the range is found in the 1st page, we need to look up
> the 2nd page, otherwise delayed-extents after a hole will be ignored.
>
> Without this patch, xfstests 225 will hung on ext4 with 1K block.
>
> Reported-by: Amir Goldstein <amir73il@users.sourceforge.net>
> Signed-off-by: Yongqiang Yang <xiaoqiangnk@gmail.com>
Thanks, added to the ext4 tree.
- Ted
prev parent reply other threads:[~2011-05-24 15:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-23 7:02 [PATCH v4] ext4:Let ext4_ext_fiemap_cb() handle blocks before request range correctly Yongqiang Yang
2011-05-24 15:42 ` Ted Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110524154212.GA26055@thunk.org \
--to=tytso@mit.edu \
--cc=amir73il@gmail.com \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=xiaoqiangnk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.