All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH] hwmon: (coretemp) Add comments describing
Date: Tue, 24 May 2011 16:26:58 +0000	[thread overview]
Message-ID: <20110524162658.GA13687@ericsson.com> (raw)
In-Reply-To: <1306184738-4933-1-git-send-email-guenter.roeck@ericsson.com>

Hi Jean,

On Tue, May 24, 2011 at 07:41:41AM -0400, Jean Delvare wrote:
> Hi Guenter,
> 
> On Mon, 23 May 2011 14:05:38 -0700, Guenter Roeck wrote:
> > The coretemp driver provides a single set of device attributes for each physical
> > core of a HT CPU to avoid duplicate sensors. This functionality was introduced
> > with commit d883b9f0977269d519469da72faec6a7f72cb489.
> > 
> > Commit e40cc4bdfd4b89813f072f72bd9c7055814d3f0f extends this functionality to
> > register the HT sibling of a CPU which is taken offline, to ensure that
> > sensor attributes are provided if at least one HT sibling of a core is online.
> > 
> > Add comments into the code describing the functionality in some more detail.
> > 
> > Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
> > Cc: Fenghua Yu <fenghua.yu@intel.com>
> > Cc: Durgadoss R <durgadoss.r@intel.com>
> > ---
> > I am not completely happy with the added comments nor with the description
> > above, so please feel free to chime in if you have an idea for a better
> > description.
> 
> The comment above looks OK to me. For the in-code comments, I have a
> few suggestions, see below.
> 

Turns out Linus already merged this version of the patch. I'll create an update patch 
for the changes and submit it.

Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

      parent reply	other threads:[~2011-05-24 16:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-23 20:42 [lm-sensors] [PATCH] hwmon: (coretemp) Add comments describing the Guenter Roeck
2011-05-24 11:41 ` [lm-sensors] [PATCH] hwmon: (coretemp) Add comments describing Jean Delvare
2011-05-24 16:26 ` Guenter Roeck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110524162658.GA13687@ericsson.com \
    --to=guenter.roeck@ericsson.com \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.