All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <cwilson@vigilantsw.com>
To: git@vger.kernel.org
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	"Junio C Hamano" <gitster@pobox.com>
Subject: [PATCH] Simple dead assignment
Date: Tue, 24 May 2011 18:45:25 -0400	[thread overview]
Message-ID: <20110524224525.GI16052@localhost> (raw)
In-Reply-To: <20110524210758.GH16052@localhost>

On Tue, May 24, 2011 at 05:07:58PM -0400, Chris Wilson wrote:
> Sentry picked up this dead assignment commited yesterday in ba67aaf.
> I've provided a patch to remove it. It might also be a good idea to
> ask the author if that value was supposed to be used for something
> in particular before pulling it out.

Oops, I see others putting the patches inline. Here you go.

Chris

-- 
Chris Wilson
http://vigilantsw.com/
Vigilant Software, LLC

diff --git a/sh-i18n--envsubst.c b/sh-i18n--envsubst.c
index 7125093..5829463 100644
--- a/sh-i18n--envsubst.c
+++ b/sh-i18n--envsubst.c
@@ -67,9 +67,6 @@ static void subst_from_stdin (void);
 int
 main (int argc, char *argv[])
 {
-  /* Default values for command line options.  */
-  unsigned short int show_variables = 0;
-
   switch (argc)
 	{
 	case 1:
@@ -88,7 +85,6 @@ main (int argc, char *argv[])
 	  /* git sh-i18n--envsubst --variables '$foo and $bar' */
 	  if (strcmp(argv[1], "--variables"))
 		error ("first argument must be --variables when two are given");
-	  show_variables = 1;
       print_variables (argv[2]);
 	  break;
 	default:

  reply	other threads:[~2011-05-24 22:45 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-24 21:07 Simple dead assignment Chris Wilson
2011-05-24 22:45 ` Chris Wilson [this message]
2011-05-25  7:52   ` [PATCH] " Matthieu Moy
2011-05-25 15:06     ` [PATCH] Remove a " Chris Wilson
2011-05-25 15:50       ` Matthieu Moy
2011-05-25 17:18       ` Michael Schubert
2011-05-25 18:45         ` Chris Wilson
2011-05-25 19:11           ` Junio C Hamano
2011-05-25 19:23             ` Junio C Hamano
2011-05-25 19:45               ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110524224525.GI16052@localhost \
    --to=cwilson@vigilantsw.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.