All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@linux.intel.com>
To: "Yu, Fenghua" <fenghua.yu@intel.com>
Cc: "x86@kernel.org" <x86@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] x86, intel: Output microcode revision
Date: Tue, 24 May 2011 17:47:16 -0700	[thread overview]
Message-ID: <20110525004716.GA18742@tassilo.jf.intel.com> (raw)
In-Reply-To: <493994B35A117E4F832F97C4719C4C04011E214EC2@orsmsx505.amr.corp.intel.com>

On Tue, May 24, 2011 at 05:25:08PM -0700, Yu, Fenghua wrote:
> >@@ -300,6 +295,7 @@ static int apply_microcode(int cpu)
> >       struct ucode_cpu_info *uci;
> >      unsigned int val[2];
> >       int cpu_num;
> >+       struct cpuinfo_x86 *c = &cpu_data(cpu_num);
> 
> This is wrong. cpu_num is not initialized yet at this point. You need to assign c after cpu_num is initialized in the next statement.

Thanks. Stupid bug. I'll post an updated version.

-Andi

  parent reply	other threads:[~2011-05-25  0:48 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-24 23:03 [PATCH 1/3] x86, intel: Output microcode revision Andi Kleen
2011-05-24 23:03 ` [PATCH 2/3] x86, intel: Use cpu_update for Atom errata check Andi Kleen
2011-05-25  6:59   ` Ingo Molnar
2011-05-24 23:03 ` [PATCH 3/3] coretemp: Get microcode revision from cpu_data Andi Kleen
2011-05-24 23:58   ` Yu, Fenghua
2011-05-25  0:39   ` [PATCH 1/3] x86, intel: Output microcode revision Fenghua Yu
     [not found] ` <BANLkTikoa494-bRWtbbXuE6eqLuH0ZPUTg@mail.gmail.com>
     [not found]   ` <493994B35A117E4F832F97C4719C4C04011E214EC2@orsmsx505.amr.corp.intel.com>
2011-05-25  0:47     ` Andi Kleen [this message]
2011-05-25  6:54 ` Ingo Molnar
2011-05-25  8:00   ` Borislav Petkov
2011-05-25  9:05     ` Ingo Molnar
2011-05-25 10:50       ` Borislav Petkov
2011-05-25 11:28         ` Ingo Molnar
2011-05-25 21:08           ` Borislav Petkov
2011-05-25 11:30         ` Ingo Molnar
2011-05-25 16:54   ` Andi Kleen
2011-05-25 18:59     ` Ingo Molnar
2011-05-25 19:13       ` Andi Kleen
2011-05-25  7:06 ` Ingo Molnar
2011-05-25 16:06   ` Henrique de Moraes Holschuh
2011-05-25 16:58     ` Andi Kleen
2011-05-25 18:24       ` Ingo Molnar
2011-05-25 19:04         ` Henrique de Moraes Holschuh
2011-05-25 19:36           ` Ingo Molnar
2011-05-25 19:05         ` Andi Kleen
2011-05-25 19:45           ` Ingo Molnar
2011-05-29 10:21 ` Jan Ceuleers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110525004716.GA18742@tassilo.jf.intel.com \
    --to=ak@linux.intel.com \
    --cc=fenghua.yu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.