All of lore.kernel.org
 help / color / mirror / Atom feed
From: Amos Kong <akong@redhat.com>
To: autotest@test.kernel.org
Cc: amwang@redhat.com, kvm@vger.kernel.org
Subject: [PATCH 2/2] KVM-test: kvm_vm.py: Add quotation marks for appended	arguments
Date: Wed, 25 May 2011 10:24:49 +0800	[thread overview]
Message-ID: <20110525022449.3264.49173.stgit@t> (raw)
In-Reply-To: <BANLkTikmAAF8AP6-bZakZh7hJdfSC1CF9A@mail.gmail.com>

Appended kernel cmdline should be involved by quotation marks.
-append 'root=/dev/vda ro ..'

Reported-by: Cong Wang <amwang@redhat.com>
Signed-off-by: Amos Kong <akong@redhat.com>
---
 client/virt/kvm_vm.py |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/client/virt/kvm_vm.py b/client/virt/kvm_vm.py
index c9bb273..343488f 100644
--- a/client/virt/kvm_vm.py
+++ b/client/virt/kvm_vm.py
@@ -332,7 +332,7 @@ class VM(virt_vm.BaseVM):
             return " -initrd '%s'" % filename
 
         def add_kernel_cmdline(help, cmdline):
-            return " -append %s" % cmdline
+            return " -append '%s'" % cmdline
 
         def add_testdev(help, filename):
             return (" -chardev file,id=testlog,path=%s"

  parent reply	other threads:[~2011-05-25  2:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <BANLkTikmAAF8AP6-bZakZh7hJdfSC1CF9A@mail.gmail.com>
2011-05-25  2:24 ` [PATCH 1/2] KVM-test: control: Fix of spliting augments Amos Kong
2011-05-25  2:24 ` Amos Kong [this message]
2011-05-25  3:04   ` [PATCH 2/2] KVM-test: kvm_vm.py: Add quotation marks for appended arguments Cong Wang
2011-05-25 20:07   ` Lucas Meneghel Rodrigues

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110525022449.3264.49173.stgit@t \
    --to=akong@redhat.com \
    --cc=amwang@redhat.com \
    --cc=autotest@test.kernel.org \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.