From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Daniel Mack <zonque@gmail.com>, timur@freescale.com
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH] ALSA: ASoC: Fix comment in cs4270 codec driver
Date: Wed, 25 May 2011 19:12:55 +0800 [thread overview]
Message-ID: <20110525111254.GA10797@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1306309992-3624-1-git-send-email-zonque@gmail.com>
On Wed, May 25, 2011 at 09:53:12AM +0200, Daniel Mack wrote:
> The comment does not reflect reality anymore since the multi-component
> monster patch landed. Things are matched by names now, and not by
> exporting and referencing a struct. Fix it to avoid confusion.
>
> Signed-off-by: Daniel Mack <zonque@gmail.com>
> Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
> Cc: Liam Girdwood <lrg@slimlogic.co.uk>
CCing in Timur for his review.
> ---
> sound/soc/codecs/cs4270.c | 5 +----
> 1 files changed, 1 insertions(+), 4 deletions(-)
>
> diff --git a/sound/soc/codecs/cs4270.c b/sound/soc/codecs/cs4270.c
> index 0206a17..6cc8678 100644
> --- a/sound/soc/codecs/cs4270.c
> +++ b/sound/soc/codecs/cs4270.c
> @@ -636,10 +636,7 @@ static int cs4270_soc_resume(struct snd_soc_codec *codec)
> #endif /* CONFIG_PM */
>
> /*
> - * ASoC codec device structure
> - *
> - * Assign this variable to the codec_dev field of the machine driver's
> - * snd_soc_device structure.
> + * ASoC codec driver structure
> */
> static const struct snd_soc_codec_driver soc_codec_device_cs4270 = {
> .probe = cs4270_probe,
> --
> 1.7.5.1
>
next prev parent reply other threads:[~2011-05-25 11:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-25 7:53 [PATCH] ALSA: ASoC: Fix comment in cs4270 codec driver Daniel Mack
2011-05-25 9:55 ` Liam Girdwood
2011-05-25 11:12 ` Mark Brown [this message]
2011-05-25 18:51 ` Tabi Timur-B04825
2011-05-26 1:27 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110525111254.GA10797@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@slimlogic.co.uk \
--cc=timur@freescale.com \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.