From: Stefan Roese <sr@denx.de>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
Prashant Bhole <prashantsmailcenter@gmail.com>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
Tirumala Marri <tmarri@apm.com>
Subject: Re: Kernel cannot see PCI device
Date: Wed, 25 May 2011 11:57:12 +0200 [thread overview]
Message-ID: <201105251157.12537.sr@denx.de> (raw)
In-Reply-To: <1306273388.7481.240.camel@pasglop>
On Tuesday 24 May 2011 23:43:08 Benjamin Herrenschmidt wrote:
> On Tue, 2011-05-24 at 10:25 +0530, Prashant Bhole wrote:
> > Fixed the problem by soft resetting the PCIe port in the function
> > ppc460ex_pciex_port_init_hw().
> > Is it a right thing to do?
<snip>
> Well, it's odd that you'd have to do that, maybe something the
> bootloader is doing ?
>
> I personally don't mind but I'd like Stefan and/or Tirumala opinion on
> this.
Not sure. I had no problems with the PCIe cards I tested with the current
code. But from my experience, this card reset behavior is highly card/device
dependent.
It would be good to know that this new code doesn't break detection of other
PCIe cards/devices. Prashant, did you check this new code with other PCIe
cards/devices as well? If this patch doesn't break other PCIe cards like the
Intel PRO/1000, then:
Acked-by: Stefan Roese <sr@denx.de>
Cheers,
Stefan
next prev parent reply other threads:[~2011-05-25 9:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <BANLkTimm98Xxx8y9qM8DUSR4rTDPSFpgHw@mail.gmail.com>
[not found] ` <BANLkTi=tvyOPoN3f3v_C+NuVOwr+YKaRJA@mail.gmail.com>
2011-05-18 14:14 ` Kernel cannot see PCI device Bjorn Helgaas
2011-05-19 12:41 ` Prashant Bhole
2011-05-19 17:58 ` Bjorn Helgaas
2011-05-19 23:12 ` Benjamin Herrenschmidt
2011-05-19 23:19 ` Bjorn Helgaas
2011-05-24 4:55 ` Prashant Bhole
2011-05-24 21:43 ` Benjamin Herrenschmidt
2011-05-25 9:57 ` Stefan Roese [this message]
2011-05-25 10:48 ` Prashant Bhole
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201105251157.12537.sr@denx.de \
--to=sr@denx.de \
--cc=benh@kernel.crashing.org \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=prashantsmailcenter@gmail.com \
--cc=tmarri@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.