From: Christoph Hellwig <hch@lst.de>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qcow2: Fix in-flight list after qcow2_cache_put failure
Date: Wed, 25 May 2011 15:20:26 +0200 [thread overview]
Message-ID: <20110525132026.GA2557@lst.de> (raw)
In-Reply-To: <1306248439-7310-1-git-send-email-kwolf@redhat.com>
On Tue, May 24, 2011 at 04:47:19PM +0200, Kevin Wolf wrote:
> If qcow2_cache_put returns an error during cluster allocation and the
> allocation fails, it must be removed from the list of in-flight allocations.
> Otherwise we'd get a loop in the list when the ACB is used for the next
> allocation.
>
> Luckily, this qcow2_cache_put shouldn't fail anyway because the L2 table is
> only read, so that qcow2_cache_put doesn't even involve I/O.
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2011-05-25 14:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-24 14:47 [Qemu-devel] [PATCH] qcow2: Fix in-flight list after qcow2_cache_put failure Kevin Wolf
2011-05-25 13:20 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110525132026.GA2557@lst.de \
--to=hch@lst.de \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.