From: Johan Hedberg <johan.hedberg@gmail.com>
To: ext-jablonski.radoslaw@nokia.com
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: Question about ABORT when canceling OPP file transfer
Date: Wed, 25 May 2011 13:17:56 -0700 [thread overview]
Message-ID: <20110525201756.GA18489@dell.amr.corp.intel.com> (raw)
In-Reply-To: <F41BD0C0A0991E449426F6CEE2BF5779014724@008-AM1MPN1-014.mgdnok.nokia.com>
Hi Radek,
On Wed, May 25, 2011, ext-jablonski.radoslaw@nokia.com wrote:
> There is one PTS test for OPP which tests if we're disconnecting
> cleanly when cancelling outgoing file transfer (this test is not
> mandatory). Currently it fails, because we don't send ABORT before
> disconnect.
>
> I've noticed that code for handling it nicely already exist in
> gw_obex_xfer_do_abort(...) but is disabled by default (via
> USE_NICE_ABORT definition).
>
> Is it safe to change that and use "nice abort" by default? Were there
> problems with handling this ABORT command by some devices in described
> scenario?
I think this is just a packaging bug. There's no reason to disable the
"nice abort" feature. Actually, I think it'd be fine not to have this
configurable for gwobex but always enable it (it's a legacy from really
old OpenOBEX versions that didn't yet support sending the Abort
command).
Johan
prev parent reply other threads:[~2011-05-25 20:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-25 7:39 Question about ABORT when canceling OPP file transfer ext-jablonski.radoslaw
2011-05-25 11:50 ` Luiz Augusto von Dentz
2011-05-25 16:43 ` Tom Allebrandi
2011-05-25 20:17 ` Johan Hedberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110525201756.GA18489@dell.amr.corp.intel.com \
--to=johan.hedberg@gmail.com \
--cc=ext-jablonski.radoslaw@nokia.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.