From: Ted Ts'o <tytso@mit.edu>
To: Yongqiang Yang <xiaoqiangnk@gmail.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH v2] ext4:Teach ext4_ext_split to caculate extents efficiently.
Date: Wed, 25 May 2011 18:02:33 -0400 [thread overview]
Message-ID: <20110525220233.GD9520@thunk.org> (raw)
In-Reply-To: <BANLkTimbiL07BQyF8rgoBVh4apY5ZJdiCA@mail.gmail.com>
On Wed, May 25, 2011 at 10:02:37AM +0800, Yongqiang Yang wrote:
> path[i]p_idx is mutated to EXT_MAX_INDEX(path[i].p_hdr) + 1, it is
> meaningless. ext4_ext_split() is used only by
> ext4_ext_create_new_leaf() which drops the path after ext4_ext_split()
> returns, so the path[i].p_idx is no longer used.
>
> I had tested the patch with fsx. I am not sure if this test is
> enough. If you want more tests, I can do it.
OK, thanks for the explanation. Sometimes testing doesn't find
problems, so I try to understand the patch and make sure it is sane.
I noticed that your path[i].p_ext and path[i].p_idx were no longer
being updated with your patch; I was able to convince myself that
p_ext didn't matter, but I wasn't entirely sure about p_idx, so that's
why I asked you.
I've added it to the ext4 dev tree.
- Ted
prev parent reply other threads:[~2011-05-25 22:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-23 9:30 [PATCH v2] ext4:Teach ext4_ext_split to caculate extents efficiently Yongqiang Yang
2011-05-24 21:07 ` Ted Ts'o
2011-05-25 2:02 ` Yongqiang Yang
2011-05-25 22:02 ` Ted Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110525220233.GD9520@thunk.org \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=xiaoqiangnk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.