All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean-Francois Moine <moinejf@free.fr>
To: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: Hans Petter Selasky <hselasky@c2i.net>,
	"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>
Subject: Re: [PATCH] Make nchg variable signed because the code compares this variable against negative values.
Date: Thu, 26 May 2011 08:48:15 +0200	[thread overview]
Message-ID: <20110526084815.48a35684@tele> (raw)
In-Reply-To: <4DDD99B5.2050105@redhat.com>

On Wed, 25 May 2011 21:07:17 -0300
Mauro Carvalho Chehab <mchehab@redhat.com> wrote:

> This patch looks ok to me, although the description is not 100%. 
> 
> The sonixj driver compares the value for nchg with
> 		if (sd->nchg < -6 || sd->nchg >= 12) {
> 
> With u8, negative values won't work.
> 
> Please check.

Hi Mauro and Hans Petter,

With all the messages in the list, I did not noticed this patch.

Indeed, the fix is correct. I was wondering why there were still
problems with the image size in sonixj. They should disappear now.

Thanks.

-- 
Ken ar c'hentañ	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/

      reply	other threads:[~2011-05-26  6:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-23 11:09 [PATCH] Make nchg variable signed because the code compares this variable against negative values Hans Petter Selasky
2011-05-26  0:07 ` Mauro Carvalho Chehab
2011-05-26  6:48   ` Jean-Francois Moine [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110526084815.48a35684@tele \
    --to=moinejf@free.fr \
    --cc=hselasky@c2i.net \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.