From: Guenter Roeck <guenter.roeck@ericsson.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH v2] MAX6642: Better detection schema
Date: Thu, 26 May 2011 13:52:15 +0000 [thread overview]
Message-ID: <20110526135215.GB29291@ericsson.com> (raw)
In-Reply-To: <4DDE50E5.5040902@appeartv.com>
On Thu, May 26, 2011 at 09:08:53AM -0400, Per Dalén wrote:
> Changed according to the suggestions from Guenter Roeck:
>
> * Check the manufacturer ID directly. Fastens the test if it's not a
> Maxim chip.
> * Read the other non-existing registers after the manufacturer ID.
>
> ---
> Check for non-existing registers, registers 0x04, 0x06 and 0xff, which
> are supported by other Maxim chips. Reading such registers returns the
> previously read value.
>
> Signed-off-by: Per Dalen <per.dalen@appeartv.com>
Applied, with a couple of spelling errors fixed.
> ---
On a side note, your comments from above should go here. As written, the comments
end up in the commit log, but the description and your signature don't.
Thanks,
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2011-05-26 13:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-26 13:08 [lm-sensors] [PATCH v2] MAX6642: Better detection schema Per Dalén
2011-05-26 13:52 ` Guenter Roeck [this message]
2011-05-26 19:39 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110526135215.GB29291@ericsson.com \
--to=guenter.roeck@ericsson.com \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.