All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Xiangliang Yu <yuxiangl@marvell.com>
Cc: "James.Bottomley@suse.de" <James.Bottomley@suse.de>,
	"jslaby@suse.cz" <jslaby@suse.cz>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Jacky Feng <jfeng@marvell.com>
Subject: Re: [PATCH 3/9] [SCSI] mvsas: Add driver version and interrupt coalescing to device 	attributes in sysfs
Date: Thu, 26 May 2011 07:14:30 -0700	[thread overview]
Message-ID: <20110526141430.GD4164@kroah.com> (raw)
In-Reply-To: <F766E4F80769BD478052FB6533FA745D19FAD846E0@SC-VEXCH4.marvell.com>

On Thu, May 26, 2011 at 02:00:21AM -0700, Xiangliang Yu wrote:
> 
> >Subject: Re: [PATCH 3/9] [SCSI] mvsas: Add driver version and interrupt >coalescing to device attributes in sysfs
> >> 
> >> -- Add support for driver version and interrupt coalescing device attributes.
> 
> >When you add a sysfs file, you must also add a Documentation/ABI file as
> >well.  Please do that here.
> 
> These device attributes are sysft class properties for the scsi host,
> and the sysfs files are within scsi host sysfs directory. so, do you
> think I need add a ABI file?  and , I can't find anything about scsi
> host sysfs file under directory Documentation/ABI.

Yes, again, if you add a sysfs file, you need to add documentation
explaining exactly what it is there for and what it does.

And if there isn't already a file for this device, then please add it.

thanks,

greg k-h

  reply	other threads:[~2011-05-26 14:14 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <mvsas-intr-coal>
2011-05-24 14:31 ` [PATCH 3/9] [SCSI] mvsas: Add driver version and interrupt coalescing to device attributes in sysfs yxlraid
2011-05-26  2:18   ` Greg KH
2011-05-26  9:00     ` Xiangliang Yu
2011-05-26 14:14       ` Greg KH [this message]
2011-05-27  3:23         ` Xiangliang Yu
2011-05-27  7:33           ` Greg KH
2011-05-30  7:26             ` Xiangliang Yu
2011-05-30  7:45               ` Greg KH
2011-05-30 11:22                 ` Xiangliang Yu
2011-05-30 14:48                   ` Greg KH
2011-05-31  7:26                     ` Xiangliang Yu
2011-05-31  7:41                       ` Greg KH
2011-05-31  8:52                         ` Xiangliang Yu
2011-05-31  8:52                           ` Xiangliang Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110526141430.GD4164@kroah.com \
    --to=greg@kroah.com \
    --cc=James.Bottomley@suse.de \
    --cc=jfeng@marvell.com \
    --cc=jslaby@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=yuxiangl@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.