All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nishanth Menon <nm@ti.com>
To: "Premi, Sanjeev" <premi@ti.com>
Cc: linux-omap <linux-omap@vger.kernel.org>,
	"Nayak, Rajendra" <rnayak@ti.com>
Subject: Re: [RFC][PATCH 7/9] OMAP4: powerdomain: Update MPU powerdomain for 4460
Date: Thu, 26 May 2011 07:30:22 -0700	[thread overview]
Message-ID: <20110526143020.GC2082@olorun> (raw)
In-Reply-To: <B85A65D85D7EB246BE421B3FB0FBB593024D177F92@dbde02.ent.ti.com>

On 14:22-20110526, Premi, Sanjeev wrote:
> > -----Original Message-----
> > From: linux-omap-owner@vger.kernel.org 
> > [mailto:linux-omap-owner@vger.kernel.org] On Behalf Of Menon, Nishanth
> > Sent: Thursday, May 26, 2011 7:27 AM
> > To: linux-omap
> > Cc: Nayak, Rajendra
> > Subject: [RFC][PATCH 7/9] OMAP4: powerdomain: Update MPU 
> > powerdomain for 4460
> > 
> > From: Rajendra Nayak <rnayak@ti.com>
> > 
> > The 4460 platform has changes in the MPU powerdomain,
> > hence model a new powerdomain for it and identify
> > is using the CHIP_IS_OMAP446X macro.
> > Also move all the common powerdomains to use
> > CHIP_IS_44XX so they are reused on OMAP4460.
> > 
> [snip]...[snip]
> 
> > +static struct powerdomain mpu_446x_pwrdm = {
> > +	.name		  = "mpu_pwrdm",
> > +	.prcm_offs	  = OMAP4430_PRM_MPU_INST,
> > +	.prcm_partition	  = OMAP4430_PRM_PARTITION,
> > +	.omap_chip	  = OMAP_CHIP_INIT(CHIP_IS_OMAP4460),
> 
> [sp] This change doesn't go with the description above.
>      Shouldn't this be CHIP_IS_OMAP44XX or CHIP_IS_OMAP446X
>      to be more future safe?
hmm.. similar to Vikram's comment as well. Will switch to using 6X
and 3X instead of 60 and 30 if there are no contrary opinions.
-- 
Regards,
Nishanth Menon

  reply	other threads:[~2011-05-26 14:30 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-26  1:56 [RFC][PATCH 0/9] OMAP4: Add 4460 base support Nishanth Menon
2011-05-26  1:56 ` [RFC][PATCH 1/9] OMAP: ID: introduce chip detection for OMAP4460 Nishanth Menon
2011-05-26  8:33   ` Premi, Sanjeev
2011-05-26 14:27     ` Nishanth Menon
2011-05-26 23:15       ` Kevin Hilman
2011-05-26 23:35         ` Menon, Nishanth
2011-05-26  1:56 ` [RFC][PATCH 2/9] OMAP4: HWMOD: make current hwmods common for 4460 and 4430 Nishanth Menon
2011-05-30  9:01   ` Vladimir Pantelic
2011-05-30 11:50     ` Nishanth Menon
2011-05-26  1:56 ` [RFC][PATCH 3/9] OMAP4460: HWMOD: DO not reset GPIO1 during HWMOD init Nishanth Menon
2011-05-26  8:36   ` Premi, Sanjeev
2011-05-26 14:28     ` Nishanth Menon
2011-05-26 23:24   ` Kevin Hilman
2011-05-26 23:37     ` Menon, Nishanth
2011-05-27  7:10     ` Cousson, Benoit
     [not found]       ` <BANLkTi=dHknRn5KJSh3_bG-o19BUg2AjrA@mail.gmail.com>
2011-05-27 12:16         ` Cousson, Benoit
2011-05-27 14:59         ` Kevin Hilman
2011-05-27 15:06           ` Cousson, Benoit
2011-05-27 19:35             ` Kevin Hilman
2011-05-27 19:38       ` Kevin Hilman
2011-05-29  1:11         ` Menon, Nishanth
2011-05-29 21:04         ` Steve Calfee
2011-05-30  8:32           ` Cousson, Benoit
2011-05-30 10:53           ` Koen Kooi
2011-05-26  1:56 ` [RFC][PATCH 4/9] OMAP4: clocks: distinguish 4430 and 4460 Nishanth Menon
2011-05-26  8:41   ` Premi, Sanjeev
2011-05-26  1:56 ` [RFC][PATCH 5/9] OMAP4: PRM: OMAP4460 specific PRM and CM register bitshifts Nishanth Menon
2011-05-26  1:56 ` [RFC][PATCH 6/9] OMAP4: clocks: Update the clock tree with 4460 clock nodes Nishanth Menon
2011-05-26  1:56 ` [RFC][PATCH 7/9] OMAP4: powerdomain: Update MPU powerdomain for 4460 Nishanth Menon
2011-05-26  8:52   ` Premi, Sanjeev
2011-05-26 14:30     ` Nishanth Menon [this message]
2011-05-26  1:56 ` [RFC][PATCH 8/9] OMAP4: clockdomain: Use CHIP_IS_44XX to reuse all CD's on 4460 Nishanth Menon
2011-05-26  8:47   ` Premi, Sanjeev
2011-05-26  1:56 ` [RFC][PATCH 9/9] OMAP4460: dpll: Support MPU frequencies > 1 Ghz Nishanth Menon
2011-05-26  3:16   ` Todd Poynor
2011-05-26  4:13     ` Rajendra Nayak
2011-05-26  4:53       ` Menon, Nishanth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110526143020.GC2082@olorun \
    --to=nm@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=premi@ti.com \
    --cc=rnayak@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.