From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758267Ab1EZSoC (ORCPT ); Thu, 26 May 2011 14:44:02 -0400 Received: from mail-ew0-f46.google.com ([209.85.215.46]:46854 "EHLO mail-ew0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757756Ab1EZSoA (ORCPT ); Thu, 26 May 2011 14:44:00 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=V+5+rAbh1rrGtxt3luTyb1DL7sZNreu5YORhw/LHfE+loW/T4rLCxe8htc0aL6qDUZ cWQNp32DmIOj7URLdC/gchkZXW603ZyCY3M2qRHEfhDGonxadyg+8JWYyaPT1S/NxCIV qDf8Ke15ppPMbx8XiXi/OV05Y5vW19GcUY61g= Date: Thu, 26 May 2011 21:44:02 +0300 From: Alexey Dobriyan To: Linus Torvalds Cc: KOSAKI Motohiro , benh@kernel.crashing.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, hughd@google.com, akpm@linux-foundation.org, dave@linux.vnet.ibm.com, kamezawa.hiroyu@jp.fujitsu.com Subject: Re: [PATCH] mm: don't access vm_flags as 'int' Message-ID: <20110526184402.GA2453@p183.telecom.by> References: <4DDE2873.7060409@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 26, 2011 at 10:53:34AM -0700, Linus Torvalds wrote: > 2011/5/26 KOSAKI Motohiro : > > The type of vma->vm_flags is 'unsigned long'. Neither 'int' nor > > 'unsigned int'. This patch fixes such misuse. > > I applied this, except I also just made the executive decision to > replace things with "vm_flags_t" after all. Woo-hoo! Why it is marked __nocast and not __bitwise__ like gfp_t? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail6.bemta7.messagelabs.com (mail6.bemta7.messagelabs.com [216.82.255.55]) by kanga.kvack.org (Postfix) with ESMTP id 9A8666B0022 for ; Thu, 26 May 2011 14:44:03 -0400 (EDT) Received: by ewy9 with SMTP id 9so518417ewy.14 for ; Thu, 26 May 2011 11:43:59 -0700 (PDT) Date: Thu, 26 May 2011 21:44:02 +0300 From: Alexey Dobriyan Subject: Re: [PATCH] mm: don't access vm_flags as 'int' Message-ID: <20110526184402.GA2453@p183.telecom.by> References: <4DDE2873.7060409@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: Linus Torvalds Cc: KOSAKI Motohiro , benh@kernel.crashing.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, hughd@google.com, akpm@linux-foundation.org, dave@linux.vnet.ibm.com, kamezawa.hiroyu@jp.fujitsu.com On Thu, May 26, 2011 at 10:53:34AM -0700, Linus Torvalds wrote: > 2011/5/26 KOSAKI Motohiro : > > The type of vma->vm_flags is 'unsigned long'. Neither 'int' nor > > 'unsigned int'. This patch fixes such misuse. > > I applied this, except I also just made the executive decision to > replace things with "vm_flags_t" after all. Woo-hoo! Why it is marked __nocast and not __bitwise__ like gfp_t? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org