From: Todd Poynor <toddpoynor@google.com>
To: Tony Lindgren <tony@atomide.com>,
linux-omap@vger.kernel.org, Hema HK <hemahk@ti.com>
Subject: [PATCH] ARM: OMAP2: Add missing iounmap in omap4430_phy_init
Date: Thu, 26 May 2011 12:25:53 -0700 [thread overview]
Message-ID: <20110526192553.GA21534@google.com> (raw)
!dev case needs iounmap before return.
Signed-off-by: Todd Poynor <toddpoynor@google.com>
---
arch/arm/mach-omap2/omap_phy_internal.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/omap_phy_internal.c b/arch/arm/mach-omap2/omap_phy_internal.c
index ae97336..bd563cf 100644
--- a/arch/arm/mach-omap2/omap_phy_internal.c
+++ b/arch/arm/mach-omap2/omap_phy_internal.c
@@ -56,8 +56,10 @@ int omap4430_phy_init(struct device *dev)
/* Power down the phy */
__raw_writel(PHY_PD, ctrl_base + CONTROL_DEV_CONF);
- if (!dev)
+ if (!dev) {
+ iounmap(ctrl_base);
return 0;
+ }
phyclk = clk_get(dev, "ocp2scp_usb_phy_ick");
if (IS_ERR(phyclk)) {
--
1.7.3.1
next reply other threads:[~2011-05-26 19:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-26 19:25 Todd Poynor [this message]
2011-05-31 11:55 ` [PATCH] ARM: OMAP2: Add missing iounmap in omap4430_phy_init Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110526192553.GA21534@google.com \
--to=toddpoynor@google.com \
--cc=hemahk@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.