From: David Aguilar <davvid@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org,
"Frédéric Heitzmann" <frederic.heitzmann@gmail.com>,
"Michael J Gruber" <git@drmicha.warpmail.net>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCH v2 1/3] setup: Provide GIT_PREFIX to built-ins
Date: Thu, 26 May 2011 14:49:34 -0700 [thread overview]
Message-ID: <20110526214918.GA22623@gmail.com> (raw)
In-Reply-To: <7vfwo1xsn4.fsf@alter.siamese.dyndns.org>
On Thu, May 26, 2011 at 10:45:35AM -0700, Junio C Hamano wrote:
> David Aguilar <davvid@gmail.com> writes:
>
> > GIT_PREFIX was added in 7cf16a14f5c070f7b14cf28023769450133172ae so that
> > aliases can know the directory from which a !alias was called.
> >
> > Knowing the prefix relative to the root is helpful in other programs
> > so export it to built-ins as well.
> >
> > Signed-off-by: David Aguilar <davvid@gmail.com>
> > ---
> >
> > The original version of this patch did not set GIT_PREFIX
> > to an empty string when prefix returns NULL.
> > Now we do.
>
> Thanks. Should I add "Helped-by: MJG"?
Yes, that'd be great.
--
David
prev parent reply other threads:[~2011-05-26 21:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-26 3:37 [PATCH v2 1/3] setup: Provide GIT_PREFIX to built-ins David Aguilar
2011-05-26 3:37 ` [PATCH v2 2/3] git: Remove handling for GIT_PREFIX David Aguilar
2011-05-26 3:37 ` [PATCH v2 3/3] git-mergetool--lib: Make vimdiff retain the current directory David Aguilar
2011-05-26 5:05 ` David Aguilar
2011-05-26 5:29 ` [PATCH] " David Aguilar
2011-05-26 6:21 ` [PATCH v4 3/3] " David Aguilar
2011-05-26 17:45 ` [PATCH v2 1/3] setup: Provide GIT_PREFIX to built-ins Junio C Hamano
2011-05-26 21:49 ` David Aguilar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110526214918.GA22623@gmail.com \
--to=davvid@gmail.com \
--cc=avarab@gmail.com \
--cc=frederic.heitzmann@gmail.com \
--cc=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.